From c7c86ed22cd162340f0378d2826d4916e4bc5343 Mon Sep 17 00:00:00 2001
From: xiexs <xiexs@cn.fujitsu.com>
Date: Fri, 27 Nov 2015 04:14:06 -0500
Subject: [PATCH] Optimize "open" method with context manager

Use opening context manager to open a file.

Change-Id: Ib03c6b4d70f31178031124fe1ff99c6fbd0e3966
---
 doc/source/conf.py | 95 ++++++++++++++++++++++------------------------
 1 file changed, 46 insertions(+), 49 deletions(-)

diff --git a/doc/source/conf.py b/doc/source/conf.py
index ebb5c7f933..ac308f7e02 100644
--- a/doc/source/conf.py
+++ b/doc/source/conf.py
@@ -81,8 +81,8 @@ def write_autodoc_index():
         os.mkdir(RSTDIR)
     CURRENT_SOURCES[RSTDIR] = ['autoindex.rst']
 
-    INDEXOUT = open(os.path.join(RSTDIR, "autoindex.rst"), "w")
-    INDEXOUT.write("""
+    with open(os.path.join(RSTDIR, "autoindex.rst"), "w") as INDEXOUT:
+        INDEXOUT.write("""
 =================
 Source Code Index
 =================
@@ -93,57 +93,54 @@ Source Code Index
 
 """)
 
-    for modulename, path in SRCS:
-        sys.stdout.write("Generating source documentation for %s\n" %
-                         modulename)
-        INDEXOUT.write("\n%s\n" % modulename.capitalize())
-        INDEXOUT.write("%s\n" % ("=" * len(modulename),))
-        INDEXOUT.write(".. toctree::\n")
-        INDEXOUT.write("   :maxdepth: 1\n")
-        INDEXOUT.write("\n")
+        for modulename, path in SRCS:
+            sys.stdout.write("Generating source documentation for %s\n" %
+                             modulename)
+            INDEXOUT.write("\n%s\n" % modulename.capitalize())
+            INDEXOUT.write("%s\n" % ("=" * len(modulename),))
+            INDEXOUT.write(".. toctree::\n")
+            INDEXOUT.write("   :maxdepth: 1\n")
+            INDEXOUT.write("\n")
 
-        MOD_DIR = os.path.join(RSTDIR, modulename)
-        CURRENT_SOURCES[MOD_DIR] = []
-        if not(os.path.exists(MOD_DIR)):
-            os.mkdir(MOD_DIR)
-        for module in find_autodoc_modules(modulename, path):
-            if any([module.startswith(exclude) for exclude
-                   in EXCLUDED_MODULES]):
-                print("Excluded module %s." % module)
-                continue
-            mod_path = os.path.join(path, *module.split("."))
-            generated_file = os.path.join(MOD_DIR, "%s.rst" % module)
+            MOD_DIR = os.path.join(RSTDIR, modulename)
+            CURRENT_SOURCES[MOD_DIR] = []
+            if not(os.path.exists(MOD_DIR)):
+                os.mkdir(MOD_DIR)
+            for module in find_autodoc_modules(modulename, path):
+                if any([module.startswith(exclude) for exclude
+                       in EXCLUDED_MODULES]):
+                    print("Excluded module %s." % module)
+                    continue
+                mod_path = os.path.join(path, *module.split("."))
+                generated_file = os.path.join(MOD_DIR, "%s.rst" % module)
 
-            INDEXOUT.write("   %s/%s\n" % (modulename, module))
+                INDEXOUT.write("   %s/%s\n" % (modulename, module))
 
-            # Find the __init__.py module if this is a directory
-            if os.path.isdir(mod_path):
-                source_file = ".".join((os.path.join(mod_path, "__init__"),
-                                        "py",))
-            else:
-                source_file = ".".join((os.path.join(mod_path), "py"))
+                # Find the __init__.py module if this is a directory
+                if os.path.isdir(mod_path):
+                    source_file = ".".join((os.path.join(mod_path, "__init__"),
+                                            "py",))
+                else:
+                    source_file = ".".join((os.path.join(mod_path), "py"))
 
-            CURRENT_SOURCES[MOD_DIR].append("%s.rst" % module)
-            # Only generate a new file if the source has changed or we don't
-            # have a doc file to begin with.
-            if not os.access(generated_file, os.F_OK) or (
-                    os.stat(generated_file).st_mtime <
-                    os.stat(source_file).st_mtime):
-                print("Module %s updated, generating new documentation."
-                      % module)
-                FILEOUT = open(generated_file, "w")
-                header = "The :mod:`%s` Module" % module
-                FILEOUT.write("%s\n" % ("=" * len(header),))
-                FILEOUT.write("%s\n" % header)
-                FILEOUT.write("%s\n" % ("=" * len(header),))
-                FILEOUT.write(".. automodule:: %s\n" % module)
-                FILEOUT.write("  :members:\n")
-                FILEOUT.write("  :undoc-members:\n")
-                FILEOUT.write("  :show-inheritance:\n")
-                FILEOUT.write("  :noindex:\n")
-                FILEOUT.close()
-
-    INDEXOUT.close()
+                CURRENT_SOURCES[MOD_DIR].append("%s.rst" % module)
+                # Only generate a new file if the source has changed or
+                # we don't have a doc file to begin with.
+                if not os.access(generated_file, os.F_OK) or (
+                        os.stat(generated_file).st_mtime <
+                        os.stat(source_file).st_mtime):
+                    print("Module %s updated, generating new documentation."
+                          % module)
+                    with open(generated_file, "w") as FILEOUT:
+                        header = "The :mod:`%s` Module" % module
+                        FILEOUT.write("%s\n" % ("=" * len(header),))
+                        FILEOUT.write("%s\n" % header)
+                        FILEOUT.write("%s\n" % ("=" * len(header),))
+                        FILEOUT.write(".. automodule:: %s\n" % module)
+                        FILEOUT.write("  :members:\n")
+                        FILEOUT.write("  :undoc-members:\n")
+                        FILEOUT.write("  :show-inheritance:\n")
+                        FILEOUT.write("  :noindex:\n")
 
     # Delete auto-generated .rst files for sources which no longer exist
     for directory, subdirs, files in list(os.walk(RSTDIR)):