openstack
/
horizon
Code Issues Proposed changes

Refresh the networks on ajax update 

If using neutron, the ajax will query the last status from
nova which could be out of date, so any floating ips
added wont show up unless you refresh the whole page.

Change-Id: Iad1684d1a2fb677ee8850a98c8219794698722e3
Closes-Bug: 1505935
This commit is contained in:
Itxaka 2015-12-11 16:07:11 +01:00
parent d4c7b8f813
commit b59ebcfaac
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openstack_dashboard/dashboards/admin/instances/tests.py
View File

@ -148,6 +148,7 @@ class InstanceViewTest(test.BaseAdminViewTests):
@test.create_stubs({api.nova: ('server_get', 'flavor_get',
'extension_supported', ),
api.network: ('servers_update_addresses',),
api.keystone: ('tenant_get',)})
def test_ajax_loading_instances(self):
server = self.servers.first()

7
openstack_dashboard/dashboards/project/instances/tables.py
View File

@ -778,6 +778,13 @@ class UpdateRow(tables.Row):
_('Unable to retrieve flavor information '
'for instance "%s".') % instance_id,
ignore=True)
try:
api.network.servers_update_addresses(request, [instance])
except Exception:
exceptions.handle(request,
_('Unable to retrieve Network information '
'for instance "%s".') % instance_id,
ignore=True)
error = get_instance_error(instance)
if error:
messages.error(request, error)

4
openstack_dashboard/dashboards/project/instances/tests.py
View File

@ -4507,6 +4507,7 @@ class InstanceAjaxTests(helpers.TestCase):
@helpers.create_stubs({api.nova: ("server_get",
"flavor_get",
"extension_supported"),
api.network: ('servers_update_addresses',),
api.neutron: ("is_extension_supported",)})
def test_row_update(self):
server = self.servers.first()
@ -4540,7 +4541,8 @@ class InstanceAjaxTests(helpers.TestCase):
@helpers.create_stubs({api.nova: ("server_get",
"flavor_get",
"extension_supported"),
api.neutron: ("is_extension_supported",)})
api.neutron: ("is_extension_supported",),
api.network: ('servers_update_addresses',)})
def test_row_update_instance_error(self):
server = self.servers.first()
instance_id = server.id