openstack
/
horizon
Code Issues Proposed changes

Reduce height for "Description" text areas 

Textarea widget defaults to 10 rows which seems unnecessary.
Reduced to 4.

Change-Id: I03cfd0087ffb1225c6ce893d98481a9a66e2ab3c
Closes-Bug: #1370271
This commit is contained in:
Cindy Lu 2014-09-17 15:03:40 -07:00
parent 20ada39b6f
commit d114dfe009
16 changed files with 32 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/dashboards/identity/domains/workflows.py
View File

@ -32,7 +32,8 @@ LOG = logging.getLogger(__name__)
class CreateDomainInfoAction(workflows.Action):
name = forms.CharField(label=_("Name"))
description = forms.CharField(widget=forms.widgets.Textarea(),
description = forms.CharField(widget=forms.widgets.Textarea(
attrs={'rows': 4}),
label=_("Description"),
required=False)
enabled = forms.BooleanField(label=_("Enabled"),

6
openstack_dashboard/dashboards/identity/groups/forms.py
View File

@ -28,7 +28,8 @@ LOG = logging.getLogger(__name__)
class CreateGroupForm(forms.SelfHandlingForm):
name = forms.CharField(label=_("Name"))
description = forms.CharField(widget=forms.widgets.Textarea(),
description = forms.CharField(widget=forms.widgets.Textarea(
attrs={'rows': 4}),
label=_("Description"),
required=False)
@ -53,7 +54,8 @@ class CreateGroupForm(forms.SelfHandlingForm):
class UpdateGroupForm(forms.SelfHandlingForm):
group_id = forms.CharField(widget=forms.HiddenInput())
name = forms.CharField(label=_("Name"))
description = forms.CharField(widget=forms.widgets.Textarea(),
description = forms.CharField(widget=forms.widgets.Textarea(
attrs={'rows': 4}),
label=_("Description"),
required=False)

2
openstack_dashboard/dashboards/identity/projects/tables.py
View File

@ -196,7 +196,7 @@ class TenantsTable(tables.DataTable):
description = tables.Column(lambda obj: getattr(obj, 'description', None),
verbose_name=_('Description'),
form_field=forms.CharField(
widget=forms.Textarea(),
widget=forms.Textarea(attrs={'rows': 4}),
required=False),
update_action=UpdateCell)
id = tables.Column('id', verbose_name=_('Project ID'))

3
openstack_dashboard/dashboards/identity/projects/workflows.py
View File

@ -124,7 +124,8 @@ class CreateProjectInfoAction(workflows.Action):
widget=forms.HiddenInput())
name = forms.CharField(label=_("Name"),
max_length=64)
description = forms.CharField(widget=forms.widgets.Textarea(),
description = forms.CharField(widget=forms.widgets.Textarea(
attrs={'rows': 4}),
label=_("Description"),
required=False)
enabled = forms.BooleanField(label=_("Enabled"),

8
openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py
View File

@ -41,7 +41,9 @@ class CreateGroup(forms.SelfHandlingForm):
'invalid': _("The string may only contain"
" ASCII characters and numbers.")},
validators=[validators.validate_slug])
description = forms.CharField(label=_("Description"))
description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea(attrs={'rows': 4}))
def handle(self, request, data):
try:
@ -68,7 +70,9 @@ class UpdateGroup(forms.SelfHandlingForm):
'invalid': _("The string may only contain"
" ASCII characters and numbers.")},
validators=[validators.validate_slug])
description = forms.CharField(label=_("Description"))
description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea(attrs={'rows': 4}))
def handle(self, request, data):
try:

2
openstack_dashboard/dashboards/project/data_processing/cluster_templates/workflows/create.py
View File

@ -98,7 +98,7 @@ class GeneralConfigAction(workflows.Action):
description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea)
widget=forms.Textarea(attrs={'rows': 4}))
anti_affinity = aa.anti_affinity_field()

2
openstack_dashboard/dashboards/project/data_processing/clusters/workflows/create.py
View File

@ -72,7 +72,7 @@ class GeneralConfigAction(workflows.Action):
description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea)
widget=forms.Textarea(attrs={'rows': 4}))
cluster_template = forms.ChoiceField(label=_("Cluster Template"),
initial=(None, "None"))

2
openstack_dashboard/dashboards/project/data_processing/data_image_registry/forms.py
View File

@ -29,7 +29,7 @@ class ImageForm(forms.SelfHandlingForm):
description = forms.CharField(max_length=80,
label=_("Description"),
required=False,
widget=forms.Textarea())
widget=forms.Textarea(attrs={'rows': 4}))
def handle(self, request, data):
try:

2
openstack_dashboard/dashboards/project/data_processing/data_sources/workflows/create.py
View File

@ -45,7 +45,7 @@ class GeneralConfigAction(workflows.Action):
data_source_description = forms.CharField(
label=_("Description"),
required=False,
widget=forms.Textarea)
widget=forms.Textarea(attrs={'rows': 4}))
def __init__(self, request, *args, **kwargs):
super(GeneralConfigAction, self).__init__(request, *args, **kwargs)

3
openstack_dashboard/dashboards/project/data_processing/job_binaries/forms.py
View File

@ -63,7 +63,8 @@ class JobBinaryCreateForm(forms.SelfHandlingForm):
job_binary_script = forms.CharField(label=_("Script text"),
required=False,
widget=forms.Textarea())
widget=forms.Textarea(
attrs={'rows': 4}))
job_binary_username = forms.CharField(label=_("Username"),
required=False)

2
openstack_dashboard/dashboards/project/data_processing/jobs/workflows/create.py
View File

@ -64,7 +64,7 @@ class GeneralConfigAction(workflows.Action):
job_description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea)
widget=forms.Textarea(attrs={'rows': 4}))
def populate_job_type_choices(self, request, context):
choices = [("Pig", _("Pig")), ("Hive", _("Hive")),

2
openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/workflows/create.py
View File

@ -38,7 +38,7 @@ class GeneralConfigAction(workflows.Action):
description = forms.CharField(label=_("Description"),
required=False,
widget=forms.Textarea)
widget=forms.Textarea(attrs={'rows': 4}))
flavor = forms.ChoiceField(label=_("OpenStack Flavor"))

2
openstack_dashboard/dashboards/project/instances/forms.py
View File

@ -113,7 +113,7 @@ class DecryptPasswordInstanceForm(forms.SelfHandlingForm):
_keypair_name_label = _("Key Pair Name")
_keypair_name_help = _("The Key Pair name that "
"was associated with the instance")
_attrs = {'readonly': 'readonly'}
_attrs = {'readonly': 'readonly', 'rows': 4}
keypair_name = forms.CharField(widget=forms.widgets.TextInput(_attrs),
label=_keypair_name_label,
help_text=_keypair_name_help,

2
openstack_dashboard/dashboards/project/volumes/backups/forms.py
View File

@ -31,7 +31,7 @@ from openstack_dashboard.dashboards.project.containers \
class CreateBackupForm(forms.SelfHandlingForm):
name = forms.CharField(max_length=255, label=_("Backup Name"))
description = forms.CharField(widget=forms.Textarea,
description = forms.CharField(widget=forms.Textarea(attrs={'rows': 4}),
label=_("Description"),
required=False)
container_name = forms.CharField(

4
openstack_dashboard/dashboards/project/volumes/snapshots/forms.py
View File

@ -23,8 +23,8 @@ from openstack_dashboard.api import cinder
class UpdateForm(forms.SelfHandlingForm):
name = forms.CharField(max_length=255, label=_("Snapshot Name"))
description = forms.CharField(max_length=255, widget=forms.Textarea,
label=_("Description"), required=False)
description = forms.CharField(max_length=255, widget=forms.Textarea(
attrs={'rows': 4}), label=_("Description"), required=False)
def handle(self, request, data):
snapshot_id = self.initial['snapshot_id']

10
openstack_dashboard/dashboards/project/volumes/volumes/forms.py
View File

@ -46,7 +46,7 @@ DEFAULT_CONTAINER_FORMAT = 'bare'
class CreateForm(forms.SelfHandlingForm):
name = forms.CharField(max_length=255, label=_("Volume Name"))
description = forms.CharField(max_length=255, widget=forms.Textarea(
attrs={'class': 'modal-body-fixed-width'}),
attrs={'class': 'modal-body-fixed-width', 'rows': 4}),
label=_("Description"), required=False)
volume_source_type = forms.ChoiceField(label=_("Volume Source"),
required=False,
@ -470,8 +470,8 @@ class AttachForm(forms.SelfHandlingForm):
class CreateSnapshotForm(forms.SelfHandlingForm):
name = forms.CharField(max_length=255, label=_("Snapshot Name"))
description = forms.CharField(max_length=255, widget=forms.Textarea,
label=_("Description"), required=False)
description = forms.CharField(max_length=255, widget=forms.Textarea(
attrs={'rows': 4}), label=_("Description"), required=False)
def __init__(self, request, *args, **kwargs):
super(CreateSnapshotForm, self).__init__(request, *args, **kwargs)
@ -508,8 +508,8 @@ class CreateSnapshotForm(forms.SelfHandlingForm):
class UpdateForm(forms.SelfHandlingForm):
name = forms.CharField(max_length=255, label=_("Volume Name"))
description = forms.CharField(max_length=255, widget=forms.Textarea,
label=_("Description"), required=False)
description = forms.CharField(max_length=255, widget=forms.Textarea(
attrs={'rows': 4}), label=_("Description"), required=False)
def handle(self, request, data):
volume_id = self.initial['volume_id']