Re-enable extra data collection during introspection

It was initially disabled for Liberty, as Liberty IPA images used to not
contain the required dependency (python-hardware-detect package).
However, after more discussions we decided that it's valuable to continue
having extra hardware data by default, as it used to be in Kilo
instack-undercloud.

The required package was in IPA since January.

Change-Id: Iccaefe72f2795dfb855a3b321c28328aef219d6b

instack_undercloud/tests/test_undercloud.py

@@ -217,7 +217,7 @@ class TestGenerateEnvironment(BaseTestCase):
         env = undercloud._generate_environment('.')
         # Just spot check, we don't want to replicate the entire opt list here
         self.assertEqual(env['INSPECTION_COLLECTORS'],
-                         'default,logs')
+                         'default,extra-hardware,logs')
         self.assertEqual('192.0.2.1/24', env['PUBLIC_INTERFACE_IP'])
         self.assertEqual('192.0.2.1', env['LOCAL_IP'])
 

instack_undercloud/undercloud.py

@@ -163,7 +163,7 @@ _opts = [
                      'be in the same network.')
                ),
     cfg.BoolOpt('inspection_extras',
-                default=False,
+                default=True,
                 help=('Whether to enable extra hardware collection during '
                       'the inspection process. Requires python-hardware or '
                       'python-hardware-detect package on the introspection '

undercloud.conf.sample

@@ -71,7 +71,7 @@
 # Whether to enable extra hardware collection during the inspection
 # process. Requires python-hardware or python-hardware-detect package
 # on the introspection image. (boolean value)
-#inspection_extras = false
+#inspection_extras = true
 
 # Whether to run benchmarks when inspecting nodes. Requires
 # inspection_extras set to True. (boolean value)