Update patch set 1

Patch Set 1:

(2 comments)

This change is ready for review.

Patch-set: 1
Work-in-progress: false
Attention: {"person_ident":"Gerrit User 10342 \u003c10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35233\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35233\u003e replied on the change"}
This commit is contained in:
Gerrit User 35233 2024-02-13 18:03:33 +00:00 committed by Gerrit Code Review
parent 10ffa3698b
commit 907da40bc2
1 changed files with 36 additions and 0 deletions

View File

@ -50,6 +50,42 @@
"message": "It\u0027ll take an incredibly strong use case and justification to make it OK to ignore failures on disk cleaning. In fact, I\u0027d suggest that most things that fail disk cleaning are unlikely to deploy in the future -- either due to the cleaning itself failing (leaving behind things on disk) or due to it seeing another error when deploying.\n\nPlease include some details (maybe a bug ticket?) with the exact cases you\u0027re running into. We should try to find alternative solutions -- I consider it a security risk to permit cleaning to fail silently.",
"revId": "28e15032779f98242e6291b2975952483115a1e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1fb996ff_cca7b380",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 35233
},
"writtenOn": "2024-02-13T18:03:33Z",
"side": 1,
"message": "I have no intention to change this code along the current logic, I needed a public branch to share code with some folks who have special hardware problems and I am investigating, that is why I put a -1 on the PR, tagged as a WIP and wrote a comment to please don\u0027t review it. It wasn\u0027t my intention to cause worry or to submit a half baked change without a bug ticket, I will put this info to the commit message also.\n\nSorry for the troubles!",
"parentUuid": "1cffde80_2afb7348",
"revId": "28e15032779f98242e6291b2975952483115a1e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7a63e73f_bff6f018",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 35233
},
"writtenOn": "2024-02-13T18:03:33Z",
"side": 1,
"message": "Don\u0027t worry this was not a proposal neither a real feature I put -1 on it and it was taged as a draft, I assume something is wrong with gerrit because it has lost the WIP flag and if you check the history I set it to WIP I have also mentioned to please don\u0027t\n review it I will write a more detailed description. \n\nThe story of this PR is that I am investigation a wierd issue but I can\u0027t run the tests myself so I have made a draft PR and shared with the folks who has the hardware.\n\nI am sorry, It wasn\u0027t my intention to worry anyone.",
"parentUuid": "2491b809_e95aa4c5",
"revId": "28e15032779f98242e6291b2975952483115a1e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}