Update patch set 13
Patch Set 13: Code-Review-1 (3 comments) This change is ready for review. Patch-set: 13 Reviewer: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 24d6ddc3fb304696fc9ef41a13ba0aeb01dec315 Work-in-progress: false Attention: {"person_ident":"Gerrit User 22629 \u003c22629@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
This commit is contained in:
parent
40da3f6413
commit
27e96e3803
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4a4e514a_46d7bb48",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 11655
|
||||
},
|
||||
"writtenOn": "2024-05-10T21:02:34Z",
|
||||
"side": 1,
|
||||
"message": "Some more work is required since we can\u0027t just expect everyone is going to do lvm raid.",
|
||||
"revId": "30ae9fcc3ed6419106f7d08fc639e7023d9650fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4245b603_714873d7",
|
||||
"filename": "ironic_python_agent/hardware.py",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 620,
|
||||
"author": {
|
||||
"id": 11655
|
||||
},
|
||||
"writtenOn": "2024-05-10T21:02:34Z",
|
||||
"side": 1,
|
||||
"message": "slight problem with only checking an lvm device as a partition of a disk, you can have an entire physical device as an lvm pv.",
|
||||
"range": {
|
||||
"startLine": 620,
|
||||
"startChar": 22,
|
||||
"endLine": 620,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "30ae9fcc3ed6419106f7d08fc639e7023d9650fe",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "dd4d802f_f8536195",
|
||||
"filename": "ironic_python_agent/hardware.py",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 612,
|
||||
"author": {
|
||||
"id": 11655
|
||||
},
|
||||
"writtenOn": "2024-05-10T21:02:34Z",
|
||||
"side": 0,
|
||||
"message": "md devices still need to be checked.",
|
||||
"range": {
|
||||
"startLine": 612,
|
||||
"startChar": 21,
|
||||
"endLine": 612,
|
||||
"endChar": 47
|
||||
},
|
||||
"revId": "c303bd971b055f34d5725550ed41c7d67e3eaeb5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue