Update patch set 5
Patch Set 5: Code-Review-1 (3 comments) Patch-set: 5 Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 8a3a41de4ec72d4e47a925e26b14b456b199ebe5
This commit is contained in:
parent
ff57f3deb9
commit
34e44b3890
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2306573a_955b1a00",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 10342
|
||||
},
|
||||
"writtenOn": "2024-05-07T20:17:06Z",
|
||||
"side": 1,
|
||||
"message": "Please remove the unrelated whitespace changes. \n\nThis change also needs a release note -- you can add one by running `tox -e venv -- reno new add-bmc-subnet-info` and editing+committing the resulting yaml file\n\nThanks for the submission!",
|
||||
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0e93bfff_5986bc25",
|
||||
"filename": "ironic_python_agent/hardware.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 10342
|
||||
},
|
||||
"writtenOn": "2024-05-07T20:17:06Z",
|
||||
"side": 1,
|
||||
"message": "Unrelated whitespace change here and throughout. Please ensure your changes are limited to what you\u0027re meaning to adjust -- I suspect your IDE may have reformatted the whole file and created these unintended whitespace changes.",
|
||||
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "cd20cbba_e6bd5ca5",
|
||||
"filename": "ironic_python_agent/hardware.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 2356,
|
||||
"author": {
|
||||
"id": 10342
|
||||
},
|
||||
"writtenOn": "2024-05-07T20:17:06Z",
|
||||
"side": 1,
|
||||
"message": "Are we sure this mapping isn\u0027t a vendor-ism of some sort?",
|
||||
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue