openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+1

(2 comments)

Patch-set: 7
Reviewer: Gerrit User 37011 <37011@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 62f0a1404870b9b430eb69a93517fc66c779d9f7
Attention: {"person_ident":"Gerrit User 37011 \u003c37011@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
This commit is contained in:
Gerrit User 37011 2024-05-11 08:50:16 +00:00 committed by Gerrit Code Review
parent e0e8cd4a57
commit 5e527e0138
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
50e682b5cdff3fe43b746af8cb4a8baa251776e7
View File

@ -34,6 +34,24 @@
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5f618d14_a46834f8",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 5
},
"lineNbr": 145,
"author": {
"id": 37011
},
"writtenOn": "2024-05-11T08:50:16Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "0e93bfff_5986bc25",
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +68,24 @@
"message": "Are we sure this mapping isn\u0027t a vendor-ism of some sort?",
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b3758c8c_81543b81",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 5
},
"lineNbr": 2356,
"author": {
"id": 37011
},
"writtenOn": "2024-05-11T08:50:16Z",
"side": 1,
"message": "Yes, the BMC subnet, just like the BMC IP address, is always vendor-independent.\n(or have I misunderstood your question?)",
"parentUuid": "cd20cbba_e6bd5ca5",
"revId": "50e682b5cdff3fe43b746af8cb4a8baa251776e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}