diff --git a/ironic_python_agent/tests/unit/hardware_managers/test_cna.py b/ironic_python_agent/tests/unit/hardware_managers/test_cna.py index 5948bb75b..3253ad4cf 100644 --- a/ironic_python_agent/tests/unit/hardware_managers/test_cna.py +++ b/ironic_python_agent/tests/unit/hardware_managers/test_cna.py @@ -46,7 +46,7 @@ class TestIntelCnaHardwareManager(base.IronicAgentTest): mock_listdir.return_value = ['eth0', 'eth1'] mock_execute.side_effect = mock_return_execute - self.assertEqual(True, cna._detect_cna_card()) + self.assertTrue(cna._detect_cna_card()) @mock.patch.object(os, 'listdir', autospec=True) @mock.patch.object(utils, 'execute', autospec=True) @@ -61,7 +61,7 @@ class TestIntelCnaHardwareManager(base.IronicAgentTest): mock_listdir.return_value = ['eth0', 'eth1', 'eth2'] mock_execute.side_effect = mock_return_execute - self.assertEqual(False, cna._detect_cna_card()) + self.assertFalse(cna._detect_cna_card()) @mock.patch.object(os, 'listdir', autospec=True) @mock.patch.object(utils, 'execute', autospec=True) @@ -74,7 +74,7 @@ class TestIntelCnaHardwareManager(base.IronicAgentTest): mock_listdir.return_value = ['eth0', 'eth1'] mock_execute.side_effect = mock_return_execute - self.assertEqual(False, cna._detect_cna_card()) + self.assertFalse(cna._detect_cna_card()) @mock.patch.object(cna, 'LOG', autospec=True) @mock.patch.object(os, 'listdir', autospec=True) @@ -87,7 +87,7 @@ class TestIntelCnaHardwareManager(base.IronicAgentTest): with mock.patch('six.moves.builtins.open', write_mock, create=True): cna._disable_embedded_lldp_agent_in_cna_card() write_mock().write.assert_called_with('lldp stop') - self.assertEqual(False, mock_log.warning.called) + self.assertFalse(mock_log.warning.called) @mock.patch.object(cna, 'LOG', autospec=True) @mock.patch.object(os.path, 'exists', autospec=True) diff --git a/ironic_python_agent/tests/unit/test_hardware.py b/ironic_python_agent/tests/unit/test_hardware.py index 6bdae9987..3e914783f 100644 --- a/ironic_python_agent/tests/unit/test_hardware.py +++ b/ironic_python_agent/tests/unit/test_hardware.py @@ -451,7 +451,7 @@ class TestGenericHardwareManager(base.IronicAgentTest): (2, '02626172')], } result = self.hardware.collect_lldp_data(if_names) - self.assertEqual(True, if_names[0] in result) + self.assertIn(if_names[0], result) self.assertEqual(expected_lldp_data, result) @mock.patch('ironic_python_agent.netutils.get_lldp_info', autospec=True) @@ -485,7 +485,7 @@ class TestGenericHardwareManager(base.IronicAgentTest): } result = self.hardware.collect_lldp_data(if_names) mock_log.warning.assert_called_once() - self.assertEqual(True, if_names[0] in result) + self.assertIn(if_names[0], result) self.assertEqual(expected_lldp_data, result) @mock.patch('ironic_python_agent.hardware._get_managers', autospec=True)