openstack
/
ironic-tempest-plugin
Code Issues Proposed changes

Update patch set 28 

Patch Set 28:

(4 comments)

Patch-set: 28
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
This commit is contained in:
Gerrit User 11655 2023-11-03 21:55:40 +00:00 committed by Gerrit Code Review
parent 33d3304895
commit 0fa8b7ed45
4 changed files with 78 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5b0f513394da8d0d6ced12e1d484ad0535c75f81
View File

@ -16,6 +16,24 @@
"message": "We need to add a cleanup to remove the neutron port. Otherwise we can\u0027t delete the network.",
"revId": "5b0f513394da8d0d6ced12e1d484ad0535c75f81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e292ea0f_dc62768f",
"filename": "ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py",
"patchSetId": 22
},
"lineNbr": 373,
"author": {
"id": 11655
},
"writtenOn": "2023-11-03T21:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "9a2d8645_7dfec1cb",
"revId": "5b0f513394da8d0d6ced12e1d484ad0535c75f81",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
610397fe831d3816cc00aa30014053d36a67e1c7
View File

@ -16,6 +16,24 @@
"message": "Well, that didn\u0027t work... we apparently angered something,, no errors were generated but went direct to cleanup.",
"revId": "610397fe831d3816cc00aa30014053d36a67e1c7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "871a92d8_935f5f6a",
"filename": "ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py",
"patchSetId": 25
},
"lineNbr": 368,
"author": {
"id": 11655
},
"writtenOn": "2023-11-03T21:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "493bf0cb_72c7ae01",
"revId": "610397fe831d3816cc00aa30014053d36a67e1c7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
d5d6931335ca635933914e6e3a2c1c91fb8511f3
View File

@ -22,6 +22,30 @@
},
"revId": "d5d6931335ca635933914e6e3a2c1c91fb8511f3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d1523454_0bbfe185",
"filename": "ironic_tempest_plugin/tests/scenario/ironic_standalone/test_advanced_ops.py",
"patchSetId": 1
},
"lineNbr": 107,
"author": {
"id": 11655
},
"writtenOn": "2023-11-03T21:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "78dc7dfb_f72f6930",
"range": {
"startLine": 107,
"startChar": 8,
"endLine": 107,
"endChar": 32
},
"revId": "d5d6931335ca635933914e6e3a2c1c91fb8511f3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
fcc3a9a0a7a176993eeb72182e0f84defcf22aab
View File

@ -16,6 +16,24 @@
"message": "vifs are already gone, we clear it on unprovision *gah*",
"revId": "fcc3a9a0a7a176993eeb72182e0f84defcf22aab",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "eab53215_8509ebb1",
"filename": "ironic_tempest_plugin/tests/scenario/ironic_standalone/test_advanced_ops.py",
"patchSetId": 24
},
"lineNbr": 145,
"author": {
"id": 11655
},
"writtenOn": "2023-11-03T21:55:40Z",
"side": 1,
"message": "Done",
"parentUuid": "ae23cc88_45e0d38e",
"revId": "fcc3a9a0a7a176993eeb72182e0f84defcf22aab",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}