Update patch set 4

Patch Set 4: (9 comments) Patch-set: 4 CC: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
2024-03-26 00:07:43 +00:00 · 2024-03-26 00:07:43 +00:00 · 175253d879
parent 89722c213a
commit 175253d879
1 changed files with 175 additions and 0 deletions
--- a/175
+++ b/175
@ -0,0 +1,175 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6b4836b1_01b9e228",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_allocations.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 218,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "IF you can enumerate on the why a little bit more, that would be helpful for anyone coming along in the future. Thanks!",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1fc9d547_bbcd8a37",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_allocations.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 220,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "I initially sas this and thought \"min_microversion\", This makes more sense now. An inline note might help too. Thanks!",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6e1baf82_e9f7908d",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_allocations.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 257,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "Same as above. Just a little more inline detail since \"No\" in the class name might not be the higgest hint for folks.",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "91171eac_07fbf29a",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_allocations.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 283,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "One thing, and hopefully not an existing bug elsewhere, but we need to somewhere ensure that we do ensure the node/allocation is all cleaned up. The plugin might properly unwind it all, but I just want us to be sure.",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "80fe0f3b_a0251598",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_deploy_templates.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 200,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "A little bit more verbosity in the description please.",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b0f4d336_bc8d406a",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_deploy_templates.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 230,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "A little more verbosity in the description please. 😊",
+      "range": {
+        "startLine": 230,
+        "startChar": 4,
+        "endLine": 230,
+        "endChar": 37
+      },
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "55c05ee3_2d3d9e5b",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_nodes.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 229,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "s/older/newer/",
+      "range": {
+        "startLine": 229,
+        "startChar": 0,
+        "endLine": 229,
+        "endChar": 49
+      },
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a609954f_2f9992d8",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_portgroups.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 158,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "Well, ensuring it worked pre .90. Lets try and update the string to be a little more verbose. Thanks!",
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "ff0e8a83_af8cc85e",
+        "filename": "ironic_tempest_plugin/tests/api/admin/test_portgroups.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 211,
+      "author": {
+        "id": 11655
+      },
+      "writtenOn": "2024-03-26T00:07:43Z",
+      "side": 1,
+      "message": "Lets update this too to detail it is for naming without .json.",
+      "range": {
+        "startLine": 211,
+        "startChar": 5,
+        "endLine": 211,
+        "endChar": 52
+      },
+      "revId": "af623d5d2f0a164223f01e4e1a1aa0fe458f7950",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}