openstack
/
ironic
Code Issues Proposed changes

include all versions of Node in release_mappings 

For a particular ironic release, we need to include all the
possible versions of a particular object. Node (so far) has
two versions: 1.24 and 1.25 in this current release.

(Without the two versions, there could be issues upgrading
ironic from an older-master release with Node version 1.24,
to a newer-master release with Node version 1.25.)

Change-Id: I27c8d12add23ad72ea2debd1aec2bf6afaff2f90
This commit is contained in:
Ruby Loo 2018-06-28 00:07:08 +00:00
parent c45d3c1399
commit 5b4ce3d363
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/common/release_mappings.py
View File

@ -103,7 +103,7 @@ RELEASE_MAPPING = {
'api': '1.43',
'rpc': '1.44',
'objects': {
'Node': ['1.25'],
'Node': ['1.24', '1.25'],
'Conductor': ['1.2'],
'Chassis': ['1.3'],
'Port': ['1.8'],

3
ironic/tests/unit/common/test_release_mappings.py
View File

@ -78,7 +78,8 @@ class ReleaseMappingsTestCase(base.TestCase):
obj_versions = release_mappings.get_object_versions(
releases=['master'])
for obj, vers in obj_versions.items():
self.assertEqual(registered_objects[obj][0].VERSION, vers.pop())
# vers is a set of versions, not ordered
self.assertIn(registered_objects[obj][0].VERSION, vers)
def test_contains_all_db_objects(self):
self.assertIn('master', release_mappings.RELEASE_MAPPING)