From 1a4fdc4b0519b761ecbeb8955e559508dff1007b Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Wed, 24 Oct 2018 13:01:17 -0700 Subject: [PATCH] Remove the xclarity deprecation The lenovo team has setup third party CI which is reporting into gerrit the job status. While their CI is still early in the tests it executes, the log they provided to demonstrates that they were able add a node to be managed via xclarity and obtain the current boot devices. They are diligently working on making logging available, and as I understand it they will soon be running a deployment scenario. As such, I'm confident that we can go ahead and remove the deprecation notice and flags. Change-Id: I556c7ab42a74ebaa1f65642f2f18d23885de5ce3 Story: 2003097 Task: 27648 --- ironic/drivers/modules/xclarity/management.py | 9 --------- ironic/drivers/modules/xclarity/power.py | 9 --------- ironic/drivers/xclarity.py | 9 --------- .../notes/undeprecate-xclarity-4f4752017e8310e7.yaml | 10 ++++++++++ 4 files changed, 10 insertions(+), 27 deletions(-) create mode 100644 releasenotes/notes/undeprecate-xclarity-4f4752017e8310e7.yaml diff --git a/ironic/drivers/modules/xclarity/management.py b/ironic/drivers/modules/xclarity/management.py index 383d8ea481..7a3b704259 100644 --- a/ironic/drivers/modules/xclarity/management.py +++ b/ironic/drivers/modules/xclarity/management.py @@ -48,15 +48,6 @@ SUPPORTED_BOOT_DEVICES = [ class XClarityManagement(base.ManagementInterface): - # NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this - # interface was not established before Rocky cycle feature freeze. - # Lenovo is continuing to work on establishing their Third Party CI, - # and upon establishment and verification of Thid Party CI, this - # unsupported flag shall be removed. - # TODO(TheJulia): If Third Party CI is not online prior to the - # Stein Feature Freeze, this interface should be removed. - supported = False - def get_properties(self): return common.COMMON_PROPERTIES diff --git a/ironic/drivers/modules/xclarity/power.py b/ironic/drivers/modules/xclarity/power.py index 05d0c3764d..9eb6b110fc 100644 --- a/ironic/drivers/modules/xclarity/power.py +++ b/ironic/drivers/modules/xclarity/power.py @@ -32,15 +32,6 @@ xclarity_client_exceptions = importutils.try_import( class XClarityPower(base.PowerInterface): - # NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this - # interface was not established before Rocky cycle feature freeze. - # Lenovo is continuing to work on establishing their Third Party CI, - # and upon establishment and verification of Thid Party CI, this - # unsupported flag shall be removed. - # TODO(TheJulia): If Third Party CI is not online prior to the - # Stein Feature Freeze, this interface should be removed. - supported = False - def get_properties(self): return common.get_properties() diff --git a/ironic/drivers/xclarity.py b/ironic/drivers/xclarity.py index 7f1b8791e5..87b3569951 100644 --- a/ironic/drivers/xclarity.py +++ b/ironic/drivers/xclarity.py @@ -24,15 +24,6 @@ from ironic.drivers.modules.xclarity import power class XClarityHardware(generic.GenericHardware): """XClarity hardware type. """ - # NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this - # hardware type was not established before Rocky cycle feature freeze. - # Lenovo is continuing to work on establishing their Third Party CI, - # and upon establishment and verification of Thid Party CI, this - # unsupported flag shall be removed. - # TODO(TheJulia): If Third Party CI is not online prior to the - # Stein Feature Freeze, this hardware type should be removed. - supported = False - @property def supported_management_interfaces(self): """List of supported management interfaces.""" diff --git a/releasenotes/notes/undeprecate-xclarity-4f4752017e8310e7.yaml b/releasenotes/notes/undeprecate-xclarity-4f4752017e8310e7.yaml new file mode 100644 index 0000000000..667d732263 --- /dev/null +++ b/releasenotes/notes/undeprecate-xclarity-4f4752017e8310e7.yaml @@ -0,0 +1,10 @@ +--- +deprecations: + - | + The ``xclarity`` hardware type, which was previously deprecated, is no + longer deprecated. Lenovo has instituted third-party CI which is a + requirement for a driver to remain in-tree. +other: + - | + The ``xclarity`` hardware type is no longer deprecated as Lenovo + has implemented third-party CI to enable testing.