From f3eec93b83652834410a2d7461bf918adf8f89af Mon Sep 17 00:00:00 2001 From: zhangshuai <446077695@qq.com> Date: Thu, 12 Jan 2017 04:57:24 +0800 Subject: [PATCH] Provider is being get for each checkpoint In checkpoints/views.py, IndexView class, get_data() method, we list the checkpoints for a provider. After that, we iterate the checkpoints for that provider and get the provider using karbor client. This is not necessary: all the checkpoints are from the same provider, and even if they weren't, we could use karbor client to get each provider only once. Change-Id: I790116137a321570c6d386e435f24a5efde2e607 Closes-Bug: #1643331 --- karbor_dashboard/checkpoints/views.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/karbor_dashboard/checkpoints/views.py b/karbor_dashboard/checkpoints/views.py index 6a6b5ad..9a2ec7a 100644 --- a/karbor_dashboard/checkpoints/views.py +++ b/karbor_dashboard/checkpoints/views.py @@ -160,13 +160,10 @@ class IndexView(horizon_tables.DataTableView): sort_dir='asc', sort_key='name', reversed_order=reversed_order) + provider = karborclient.provider_get(self.request, provider_id) for checkpoint in checkpoints: - provider = karborclient.provider_get( - self.request, - checkpoint.protection_plan['provider_id'] - ) setattr(checkpoint, "provider_name", provider.name) - setattr(checkpoint, "provider_id", provider.id) + setattr(checkpoint, "provider_id", provider_id) except Exception: self._prev = False self._more = False