From 11ece54087f5188c0faeaa52145315def2f21afd Mon Sep 17 00:00:00 2001
From: ericxiett <eric_xiett@163.com>
Date: Sun, 11 Feb 2018 14:03:18 +0800
Subject: [PATCH] Add unit tests for trigger update API

Change-Id: I7f74c0346eef45ac83207410756e003266989bba
---
 karbor/tests/unit/api/v1/test_triggers.py | 46 +++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 mode change 100644 => 100755 karbor/tests/unit/api/v1/test_triggers.py

diff --git a/karbor/tests/unit/api/v1/test_triggers.py b/karbor/tests/unit/api/v1/test_triggers.py
old mode 100644
new mode 100755
index a9e6b092..e9ca0c85
--- a/karbor/tests/unit/api/v1/test_triggers.py
+++ b/karbor/tests/unit/api/v1/test_triggers.py
@@ -59,6 +59,14 @@ class TriggerApiTest(base.TestCase):
                 'start_time': datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'),
             },
         }
+        self.default_update_trigger_param = {
+            "name": "123",
+            "properties": {
+                "format": "crontab",
+                "pattern": "* * * * *",
+                'start_time': datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'),
+            },
+        }
 
     def test_create_trigger_InvalidBody(self):
         self.assertRaises(exception.ValidationError,
@@ -113,6 +121,44 @@ class TriggerApiTest(base.TestCase):
                           self.req,
                           trigger['trigger_info']['id'])
 
+    def test_update_trigger_InvalidID(self):
+        param = self.default_update_trigger_param.copy()
+        body = self._get_create_trigger_request_body(param)
+        self.assertRaises(exc.HTTPBadRequest,
+                          self.controller.update,
+                          self.req, 'fake-id',
+                          body=body)
+
+    def test_update_trigger_nonexist_trigger(self):
+        param = self.default_update_trigger_param.copy()
+        body = self._get_create_trigger_request_body(param)
+        self.assertRaises(exc.HTTPNotFound,
+                          self.controller.update,
+                          self.req, '42c8e647-cc13-4fc1-8d5b-b1e962290722',
+                          body=body)
+
+    def test_update_trigger_InvalidName(self):
+        trigger = self._create_one_trigger()
+
+        param = self.default_update_trigger_param.copy()
+        param['name'] = 'a' * 256
+        body = self._get_create_trigger_request_body(param)
+        self.assertRaises(ValueError,
+                          self.controller.update,
+                          self.req, trigger['trigger_info']['id'],
+                          body=body)
+
+    def test_update_trigger_miss_start_time(self):
+        trigger = self._create_one_trigger()
+
+        param = self.default_update_trigger_param.copy()
+        param['properties'].pop('start_time')
+        body = self._get_create_trigger_request_body(param)
+        self.assertRaises(exc.HTTPBadRequest,
+                          self.controller.update,
+                          self.req, trigger['trigger_info']['id'],
+                          body=body)
+
     def test_update_trigger(self):
         trigger = self._create_one_trigger()