openstack
/
keystone-tempest-plugin
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 7973 <7973@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 329eef895196a83ad4f4f172c94b5afcdc7a1cac
This commit is contained in:
Gerrit User 7973 2024-04-17 18:32:22 +00:00 committed by Gerrit Code Review
parent ac2b425aed
commit edf0b8489f
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
78d8ade0be14be8c0d245156f4ed89c860236847
View File

@ -16,6 +16,23 @@
"message": "recheck",
"revId": "78d8ade0be14be8c0d245156f4ed89c860236847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c4d5de73_063eda62",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 7973
},
"writtenOn": "2024-04-17T18:32:22Z",
"side": 1,
"message": "I somehow missed this patch. I wrote a similar patch to fix the domain tests and that patch has already merged: https://opendev.org/openstack/keystone-tempest-plugin/commit/f05f742f803a219692a48db33f3c4ddabba571bd\n\nThe change we merged for `test_domain.DomainAdminTests.test_identity_list` is a bit different in this patch. In this patch a new domain is created to be used as the tested domain_id whereas the patch that merged was just using the persona\u0027s own domain_id.\n\nI think in both cases we test access to the endpoint, but using a different id is a better test for cross-domain access.\n\nThe SRBAC gate is passing again, so this patch just needs to be rebased onto the current master branch.",
"revId": "78d8ade0be14be8c0d245156f4ed89c860236847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}