From 5dba16bc13c59e30fb05bace86779acd454f9dfa Mon Sep 17 00:00:00 2001 From: LiuNanke Date: Wed, 13 Jan 2016 22:47:14 +0800 Subject: [PATCH] Replace deprecated library function os.popen() with subprocess os.popen() is deprecated since version 2.6. Resolved with use of subprocess module. Closes-bug: #1529836 Change-Id: I3f78fff64f100aa7d435c830a2a913a521af698e --- doc/source/conf.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/source/conf.py b/doc/source/conf.py index ff4b24cc..e20477d1 100644 --- a/doc/source/conf.py +++ b/doc/source/conf.py @@ -15,6 +15,7 @@ from __future__ import unicode_literals import os +import subprocess import sys import pbr.version @@ -158,8 +159,10 @@ man_pages = [] # If not '', a 'Last updated on:' timestamp is inserted at every page bottom, # using the given strftime format. -git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1" -html_last_updated_fmt = os.popen(git_cmd).read() +git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local", + "-n1"] +html_last_updated_fmt = subprocess.Popen( + git_cmd, stdout=subprocess.PIPE).communicate()[0] # If true, SmartyPants will be used to convert quotes and dashes to # typographically correct entities.