Update patch set 18
Patch Set 18:
(12 comments)
Patch-set: 18
Attention: {"person_ident":"Gerrit User 26285 \u003c26285@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_26285\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36702 \u003c36702@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_26285\u003e replied on the change"}
This commit is contained in:
Gerrit User 26285
Gerrit Code Review
parent
a91d30c2af
commit
3212b3096a
|
|
@ -1,5 +1,22 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f85c77a9_7c45ab9a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "hi, thanks for the review. will update it soon",
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -23,6 +40,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "68713514_b22ff838",
|
||||
"filename": "ansible/roles/swift/handlers/main.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "service_name was used in the next line. \n``{{ swift_services[service_name] }}``",
|
||||
"parentUuid": "2e0b02b8_43fdc700",
|
||||
"range": {
|
||||
"startLine": 4,
|
||||
"startChar": 3,
|
||||
"endLine": 4,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -46,6 +87,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9b80e861_a5cf5e3d",
|
||||
"filename": "ansible/roles/swift/handlers/main.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 12,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "This code just was copied from other roles. \nIMO， when service.volumes is an empty string, this filter may be useful.",
|
||||
"parentUuid": "e0823ee5_db2ed43a",
|
||||
"range": {
|
||||
"startLine": 12,
|
||||
"startChar": 35,
|
||||
"endLine": 12,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -69,6 +134,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "24d88fa8_6dfc29d9",
|
||||
"filename": "ansible/roles/swift/handlers/main.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 74,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "This just keeps consistency with the previous code logic. but it should be fine to remove this to \"defaults/main.yaml\" theoretically",
|
||||
"parentUuid": "b70fb288_f168b2d2",
|
||||
"range": {
|
||||
"startLine": 74,
|
||||
"startChar": 4,
|
||||
"endLine": 74,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -92,6 +181,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "86b9bb20_8c234aef",
|
||||
"filename": "ansible/roles/swift/tasks/check-containers.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 12,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "It\u0027s ok here, because the default is omit. K-A has many similar usages.",
|
||||
"parentUuid": "67e19fff_48d0eaf0",
|
||||
"range": {
|
||||
"startLine": 12,
|
||||
"startChar": 4,
|
||||
"endLine": 12,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -115,6 +228,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ff5e907e_aa4b7a76",
|
||||
"filename": "ansible/roles/swift/tasks/config-disk.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 34,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "6ce3fb1c_970e9816",
|
||||
"range": {
|
||||
"startLine": 32,
|
||||
"startChar": 2,
|
||||
"endLine": 34,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -138,6 +275,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "923dd65f_90c1b179",
|
||||
"filename": "ansible/roles/swift/tasks/config.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 67,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "refer to the other roles. Kolla allows users to customize the config file by adding the config file to \"{node_custom_config}/{service}/{service_name}\"\nhowever, if we cut the \"swift-\" prefix, this will break this prescript. In this case, the users have to read the kolla-ansible code to find which directory they should put config file to.\n\nconsidering this case. I will add a new source path without \"swift-\" prefix to keep compatibility.",
|
||||
"parentUuid": "3a8c827f_34dc6423",
|
||||
"range": {
|
||||
"startLine": 67,
|
||||
"startChar": 43,
|
||||
"endLine": 67,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -161,6 +322,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1d045af4_eed115aa",
|
||||
"filename": "ansible/roles/swift/tasks/config.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 83,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "thanks for your advice. i just used one structure to copy all config files, so, it\u0027s easy to re-used.",
|
||||
"parentUuid": "0af45678_5f535741",
|
||||
"range": {
|
||||
"startLine": 83,
|
||||
"startChar": 4,
|
||||
"endLine": 83,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -184,6 +369,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "802ebf12_b4e3868e",
|
||||
"filename": "ansible/roles/swift/tasks/config.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 167,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "4a30af7b_54e859e6",
|
||||
"range": {
|
||||
"startLine": 165,
|
||||
"startChar": 4,
|
||||
"endLine": 167,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -207,6 +416,30 @@
|
|||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "46411142_521ae0eb",
|
||||
"filename": "ansible/roles/swift/tasks/config.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 189,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "ec0c1011_c7977b07",
|
||||
"range": {
|
||||
"startLine": 188,
|
||||
"startChar": 4,
|
||||
"endLine": 189,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -229,6 +462,30 @@
|
|||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "de125f8b_3fd11275",
|
||||
"filename": "ansible/roles/swift/tasks/config.yml",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 233,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "Hi, i didn\u0027t find anywhere to config this file. could you share the link to me? thanks",
|
||||
"parentUuid": "02cb5e2d_46031248",
|
||||
"range": {
|
||||
"startLine": 233,
|
||||
"startChar": 4,
|
||||
"endLine": 233,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "99044d41ef4c74be1cbb0212efdbd92b06ea73a6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -749,6 +749,24 @@
|
|||
"revId": "d421a31b03e6f067a7988a9cfc6d81c1790d78f9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e57cb70d_8b2ace5c",
|
||||
"filename": "ansible/roles/swift/tasks/config-disk.yml",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 26285
|
||||
},
|
||||
"writtenOn": "2024-05-15T10:15:45Z",
|
||||
"side": 1,
|
||||
"message": "ok, thanks for test this. these code was copied from the previous one.",
|
||||
"parentUuid": "618b7d29_863ce857",
|
||||
"revId": "d421a31b03e6f067a7988a9cfc6d81c1790d78f9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue