ovs-dpdk: add ovs-dpdkctl.sh to the role itself

Currently the ovs-dpdkctl.sh file is present in the tools
directory and the "Copying ovs-dpdkctl tool" task accesses it.

This is bad practice. Files copied from a role should either be
referenced by an absolute path or be part of the role itself.

This change moves the ovs-dpdkctl.sh file in the files
directory of the role.

Change-Id: I01459d39207e54f270f32f37b4a5153c5a819347
This commit is contained in:
Christian Berendt 2022-04-13 10:55:22 +02:00 committed by Radosław Piliszek
parent e380cdd226
commit 89659b4607
4 changed files with 6 additions and 2 deletions

View File

@ -28,7 +28,7 @@
- name: Copying ovs-dpdkctl tool - name: Copying ovs-dpdkctl tool
become: true become: true
copy: copy:
src: ../tools/ovs-dpdkctl.sh src: ovs-dpdkctl.sh
dest: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.sh" dest: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.sh"
mode: "0770" mode: "0770"

View File

@ -0,0 +1,5 @@
---
other:
- |
``tools/ovs-dpdkctl.sh`` moved to
``ansible/roles/ovs-dpdk/files/ovs-dpdkctl.sh``

View File

@ -32,7 +32,6 @@ data_files =
share/kolla-ansible/tools = tools/cleanup-containers share/kolla-ansible/tools = tools/cleanup-containers
share/kolla-ansible/tools = tools/cleanup-host share/kolla-ansible/tools = tools/cleanup-host
share/kolla-ansible/tools = tools/cleanup-images share/kolla-ansible/tools = tools/cleanup-images
share/kolla-ansible/tools = tools/ovs-dpdkctl.sh
share/kolla-ansible/doc = doc/* share/kolla-ansible/doc = doc/*
share/kolla-ansible/etc_examples = etc/* share/kolla-ansible/etc_examples = etc/*
share/kolla-ansible = tools/init-runonce share/kolla-ansible = tools/init-runonce