From 48bae90e8f12124dc4b7adb2bb38df1d114ff186 Mon Sep 17 00:00:00 2001 From: Rabi Mishra Date: Wed, 31 Oct 2018 16:42:52 +0530 Subject: [PATCH] Don't allocate pseudo-TTY when creating containers With a pseudo terminal, service is not treated as a daemon and signals would not work as expected. Change-Id: I16aa29a7924df51659d973a81d8005ae3d86f57b Related-Bug: #1799642 --- ansible/library/kolla_docker.py | 1 - tests/test_kolla_docker.py | 1 - 2 files changed, 2 deletions(-) diff --git a/ansible/library/kolla_docker.py b/ansible/library/kolla_docker.py index c177c00864..e74d0f06fd 100644 --- a/ansible/library/kolla_docker.py +++ b/ansible/library/kolla_docker.py @@ -639,7 +639,6 @@ class DockerWorker(object): 'image': self.params.get('image'), 'name': self.params.get('name'), 'volumes': volumes, - 'tty': True } def create_container(self): diff --git a/tests/test_kolla_docker.py b/tests/test_kolla_docker.py index aab7a1b343..d8374e8e08 100644 --- a/tests/test_kolla_docker.py +++ b/tests/test_kolla_docker.py @@ -133,7 +133,6 @@ FAKE_DATA = { 'image': 'myregistrydomain.com:5000/ubuntu:16.04', 'name': 'test_container', 'volumes': None, - 'tty': True }, 'images': [