From b276a9cdb52502a9abe1b0f3cf866d952f201b5d Mon Sep 17 00:00:00 2001 From: Doug Szumski Date: Thu, 15 Feb 2024 15:26:32 +0000 Subject: [PATCH] Remove the Prometheus HAProxy exporter image - The source code is no longer maintained [1] - HAProxy provides its own Prometheus metrics source [2] - In Kolla Ansible, we have merged support for using the built in metrics source [3] For these reasons, particularly the first, we should remove it immediately. [1] https://github.com/prometheus/haproxy_exporter [2] https://www.haproxy.com/blog/haproxy-exposes-a-prometheus-metrics-endpoint [3] https://review.opendev.org/c/openstack/kolla-ansible/+/877118 Change-Id: Ia30e0fc367841df3726562b57b57df0f6fbb3a81 --- .../prometheus-haproxy-exporter/Dockerfile.j2 | 23 ------------------- ...eus-haproxy-exporter-22d5af88af7e4a9d.yaml | 8 +++++++ 2 files changed, 8 insertions(+), 23 deletions(-) delete mode 100644 docker/prometheus/prometheus-haproxy-exporter/Dockerfile.j2 create mode 100644 releasenotes/notes/remove-prometheus-haproxy-exporter-22d5af88af7e4a9d.yaml diff --git a/docker/prometheus/prometheus-haproxy-exporter/Dockerfile.j2 b/docker/prometheus/prometheus-haproxy-exporter/Dockerfile.j2 deleted file mode 100644 index 5b5e1074c1..0000000000 --- a/docker/prometheus/prometheus-haproxy-exporter/Dockerfile.j2 +++ /dev/null @@ -1,23 +0,0 @@ -FROM {{ namespace }}/{{ image_prefix }}prometheus-base:{{ tag }} -{% block labels %} -LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build_date }}" -{% endblock %} - -{% block haproxy_exporter_header %}{% endblock %} - -{% block haproxy_exporter_repository_version %} -ARG haproxy_exporter_version=0.15.0 -ARG haproxy_exporter_url=https://github.com/prometheus/haproxy_exporter/releases/download/v${haproxy_exporter_version}/haproxy_exporter-${haproxy_exporter_version}.linux-{{debian_arch}}.tar.gz -{% endblock %} - -{% block haproxy_exporter_install %} -RUN curl -o /tmp/haproxy_exporter.tar.gz ${haproxy_exporter_url} \ - && tar xvf /tmp/haproxy_exporter.tar.gz -C /opt/ \ - && rm -f /tmp/haproxy_exporter.tar.gz \ - && ln -s /opt/haproxy_exporter* /opt/haproxy_exporter -{% endblock %} - -{% block haproxy_exporter_footer %}{% endblock %} -{% block footer %}{% endblock %} - -USER prometheus diff --git a/releasenotes/notes/remove-prometheus-haproxy-exporter-22d5af88af7e4a9d.yaml b/releasenotes/notes/remove-prometheus-haproxy-exporter-22d5af88af7e4a9d.yaml new file mode 100644 index 0000000000..5a0522e05b --- /dev/null +++ b/releasenotes/notes/remove-prometheus-haproxy-exporter-22d5af88af7e4a9d.yaml @@ -0,0 +1,8 @@ +--- +upgrade: + - | + HAProxy Prometheus metrics are now available directly from HAProxy. As + such, the standalone Prometheus HAProxy exporter was archived in March + 2023, is no longer supported and the Docker image has been removed from + Kolla. For further details see `here + `__.