From 90ff84013d2919b660599aa8277e154117b44dfe Mon Sep 17 00:00:00 2001 From: Daniel Mellado Date: Thu, 3 Jan 2019 07:22:04 -0500 Subject: [PATCH] Fix some misspellings within Kuryr-Kubernetes This commit fixes a few typos that were around Kuryr-Kubernetes code and attempts to keep a saner codebase avoiding one-liner committers. Change-Id: I57380d69570a74abd167ef02e6a346885bda8d5d --- CONTRIBUTING.rst | 2 +- doc/source/devref/port_crd_usage.rst | 2 +- doc/source/installation/containerized.rst | 2 +- doc/source/installation/devstack/ovn_support.rst | 4 ++-- kuryr_kubernetes/controller/drivers/base.py | 2 +- kuryr_kubernetes/controller/drivers/network_policy.py | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 6badca980..a7d90c63a 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -16,7 +16,7 @@ Bugs should be filed on Launchpad, not GitHub: https://bugs.launchpad.net/kuryr-kubernetes -If you want to have your code checked for pep8 automatically before commiting +If you want to have your code checked for pep8 automatically before committing changes, you can just do:: pip install pre-commit diff --git a/doc/source/devref/port_crd_usage.rst b/doc/source/devref/port_crd_usage.rst index 05d86b230..2633ea5a5 100644 --- a/doc/source/devref/port_crd_usage.rst +++ b/doc/source/devref/port_crd_usage.rst @@ -167,7 +167,7 @@ KuryrPorts objects that were annotated with `deleting` label at the (or any other SDN) associated resources. As for the Ports Pools, right now they reside on memory on the -Kuryr-controller and need to be recovered everytime the controller gets +Kuryr-controller and need to be recovered every time the controller gets restarted. To perform this recovery we are relying on Neutron Port device-owner information which may not be completely waterproof in all situations (e.g., if there is another entity using the same device diff --git a/doc/source/installation/containerized.rst b/doc/source/installation/containerized.rst index fce0c3cf4..c644f979a 100644 --- a/doc/source/installation/containerized.rst +++ b/doc/source/installation/containerized.rst @@ -108,7 +108,7 @@ This should generate 5 files in your ````: kuryr-cni daemonset mounts /var/run, due to necessity of accessing to several sub directories like openvswitch and auxiliary directory for vhostuser configuration and socket files. Also when neutron-openvswitch-agent works with datapath_type = netdev configuration option, kuryr-kubernetes - has to move vhostuser socket to auxilary directory, that auxiliary directory should be on the same + has to move vhostuser socket to auxiliary directory, that auxiliary directory should be on the same mount point, otherwise connection of this socket will be refused. In case when Open vSwitch keeps vhostuser socket files not in /var/run/openvswitch, openvswitch mount point in cni_ds.yaml and [vhostuser] section in config_map.yml should be changed properly. diff --git a/doc/source/installation/devstack/ovn_support.rst b/doc/source/installation/devstack/ovn_support.rst index 35d18e6d3..634e8239e 100644 --- a/doc/source/installation/devstack/ovn_support.rst +++ b/doc/source/installation/devstack/ovn_support.rst @@ -57,9 +57,9 @@ Feel free to edit it if you'd like, but it should work as-is. Note that due to OVN compiling OVS from source at /usr/local/var/run/openvswitch we need to state at the local.conf that the path -is different from the default one (i.e., /var/run/openvswtich). +is different from the default one (i.e., /var/run/openvswitch). -Optionally, the ports pool funcionality can be enabled by following: +Optionally, the ports pool functionality can be enabled by following: :doc:`./ports-pool` 5. Run DevStack. diff --git a/kuryr_kubernetes/controller/drivers/base.py b/kuryr_kubernetes/controller/drivers/base.py index 68db9ea7b..edeaf1cdd 100644 --- a/kuryr_kubernetes/controller/drivers/base.py +++ b/kuryr_kubernetes/controller/drivers/base.py @@ -757,7 +757,7 @@ class NetworkPolicyDriver(DriverBase): :param policy: dict containing Kubernetes NP object :param selector: (optional) specifc pod selector :returns: list of Pods objects affected by the policy or the selector - if it is pased + if it is passed """ raise NotImplementedError() diff --git a/kuryr_kubernetes/controller/drivers/network_policy.py b/kuryr_kubernetes/controller/drivers/network_policy.py index 912b4596f..d433b69ed 100644 --- a/kuryr_kubernetes/controller/drivers/network_policy.py +++ b/kuryr_kubernetes/controller/drivers/network_policy.py @@ -247,12 +247,12 @@ class NetworkPolicyDriver(base.NetworkPolicyDriver): elif namespace_selector: selectors = True if pod_selector: - # allow matching pods on maching namespaces + # allow matching pods on matching namespaces allowed_cidrs.extend(self._get_pods_ips( pod_selector, namespace_selector=namespace_selector)) else: - # allow from/to all on the maching namespaces + # allow from/to all on the matching namespaces allowed_cidrs.extend(self._get_namespaces_cidr( namespace_selector)) else: