openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Fix some misspellings within Kuryr-Kubernetes 

This commit fixes a few typos that were around Kuryr-Kubernetes code
and attempts to keep a saner codebase avoiding one-liner committers.

Change-Id: I57380d69570a74abd167ef02e6a346885bda8d5d
This commit is contained in:
Daniel Mellado 2019-01-03 07:22:04 -05:00
parent cf96e54bf7
commit 90ff84013d
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.rst
View File

@ -16,7 +16,7 @@ Bugs should be filed on Launchpad, not GitHub:
https://bugs.launchpad.net/kuryr-kubernetes https://bugs.launchpad.net/kuryr-kubernetes
If you want to have your code checked for pep8 automatically before commiting If you want to have your code checked for pep8 automatically before committing
changes, you can just do:: changes, you can just do::
pip install pre-commit pip install pre-commit

2
doc/source/installation/containerized.rst
View File

@ -108,7 +108,7 @@ This should generate 5 files in your ``<output_dir>``:
kuryr-cni daemonset mounts /var/run, due to necessity of accessing to several sub directories kuryr-cni daemonset mounts /var/run, due to necessity of accessing to several sub directories
like openvswitch and auxiliary directory for vhostuser configuration and socket files. Also when like openvswitch and auxiliary directory for vhostuser configuration and socket files. Also when
neutron-openvswitch-agent works with datapath_type = netdev configuration option, kuryr-kubernetes neutron-openvswitch-agent works with datapath_type = netdev configuration option, kuryr-kubernetes
has to move vhostuser socket to auxilary directory, that auxiliary directory should be on the same has to move vhostuser socket to auxiliary directory, that auxiliary directory should be on the same
mount point, otherwise connection of this socket will be refused. mount point, otherwise connection of this socket will be refused.
In case when Open vSwitch keeps vhostuser socket files not in /var/run/openvswitch, openvswitch In case when Open vSwitch keeps vhostuser socket files not in /var/run/openvswitch, openvswitch
mount point in cni_ds.yaml and [vhostuser] section in config_map.yml should be changed properly. mount point in cni_ds.yaml and [vhostuser] section in config_map.yml should be changed properly.

4
doc/source/installation/devstack/ovn_support.rst
View File

@ -57,9 +57,9 @@ Feel free to edit it if you'd like, but it should work as-is.
Note that due to OVN compiling OVS from source at Note that due to OVN compiling OVS from source at
/usr/local/var/run/openvswitch we need to state at the local.conf that the path /usr/local/var/run/openvswitch we need to state at the local.conf that the path
is different from the default one (i.e., /var/run/openvswtich). is different from the default one (i.e., /var/run/openvswitch).
Optionally, the ports pool funcionality can be enabled by following: Optionally, the ports pool functionality can be enabled by following:
:doc:`./ports-pool` :doc:`./ports-pool`
5. Run DevStack. 5. Run DevStack.

2
kuryr_kubernetes/controller/drivers/base.py
View File

@ -757,7 +757,7 @@ class NetworkPolicyDriver(DriverBase):
:param policy: dict containing Kubernetes NP object :param policy: dict containing Kubernetes NP object
:param selector: (optional) specifc pod selector :param selector: (optional) specifc pod selector
:returns: list of Pods objects affected by the policy or the selector :returns: list of Pods objects affected by the policy or the selector
if it is pased if it is passed
""" """
raise NotImplementedError() raise NotImplementedError()

4
kuryr_kubernetes/controller/drivers/network_policy.py
View File

@ -247,12 +247,12 @@ class NetworkPolicyDriver(base.NetworkPolicyDriver):
elif namespace_selector: elif namespace_selector:
selectors = True selectors = True
if pod_selector: if pod_selector:
# allow matching pods on maching namespaces # allow matching pods on matching namespaces
allowed_cidrs.extend(self._get_pods_ips( allowed_cidrs.extend(self._get_pods_ips(
pod_selector, pod_selector,
namespace_selector=namespace_selector)) namespace_selector=namespace_selector))
else: else:
# allow from/to all on the maching namespaces # allow from/to all on the matching namespaces
allowed_cidrs.extend(self._get_namespaces_cidr( allowed_cidrs.extend(self._get_namespaces_cidr(
namespace_selector)) namespace_selector))
else: else: