openstack
/
kuryr-kubernetes
Code Issues Proposed changes

Fix VIF revert on KuryrPort status update error 

There's argument number mismatch on release_vif() call while reverting
port association. This commit fixes that.

Change-Id: I54816e86910d9328d703fd7e7010d95995085cbf
This commit is contained in:
Michał Dulko 2023-01-11 18:13:11 +01:00
parent e849734c4e
commit ed9f348e87
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kuryr_kubernetes/controller/handlers/kuryrport.py
View File

@ -330,9 +330,7 @@ class KuryrPortHandler(k8s_base.ResourceEventHandler):
LOG.exception("Kubernetes Client Exception creating "
"KuryrPort CRD: %s", ex)
for ifname, data in vifs.items():
self._drv_vif_pool.release_vif(pod, data['vif'],
project_id,
security_groups)
self._drv_vif_pool.release_vif(pod, data['vif'], project_id)
self.k8s.add_event(pod, 'ExceptionOnKPUpdate', f'There was k8s '
f'client exception on updating corresponding '
f'KuryrPort CRD: {ex}', 'Warning')

3
kuryr_kubernetes/tests/unit/controller/handlers/test_kuryrport.py
View File

@ -630,8 +630,7 @@ class TestKuryrPortHandler(test_base.TestCase):
{'default': True,
'vif': self._vif1}})
release_vif.assert_called_once_with(self._pod, self._vif1,
self._project_id,
self._security_groups)
self._project_id)
@mock.patch('kuryr_kubernetes.clients.get_kubernetes_client')
@mock.patch('kuryr_kubernetes.controller.drivers.base.MultiVIFDriver.'