openstack
/
liberasurecode
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, ac86e9091fa8a51a40ad5c75564bda8d3daf5e6a
Attention: {"person_ident":"Gerrit User 36752 \u003c36752@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10342\u003e replied on the change"}
This commit is contained in:
Gerrit User 10342 2024-01-30 00:13:29 +00:00 committed by Gerrit Code Review
parent 35509dc7ec
commit 48325fa0ab
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
b9a8a5b0b8249ca63a785f092bdbb0e0402119fb
View File

@ -16,6 +16,23 @@
"message": "I discovered this issue when building liberasurecode on Gentoo, and seeing a QA warning from portage that a possibly troublesome diagnostic was detected in the configure log.",
"revId": "b9a8a5b0b8249ca63a785f092bdbb0e0402119fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "57c3bf49_e8d5ee23",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2024-01-30T00:13:29Z",
"side": 1,
"message": "I know in OpenStack we like to assume bash; but in the case of configure there appears to be no way for us to enforce having a bash shell vs any-old-posix shell.\n\nThis will fix building of some dependent software on Gentoo and really any system with /bin/sh being non-bash.",
"revId": "b9a8a5b0b8249ca63a785f092bdbb0e0402119fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}