openstack
/
magnum-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 782 \u003c782@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14394\u003e replied on the change"}
This commit is contained in:
Gerrit User 14394 2023-11-17 00:18:57 +00:00 committed by Gerrit Code Review
parent 7583ef4813
commit 8c45279ae3
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
c9ed6b72e2a915d79eb06698207986133198bf8c
View File

@ -51,6 +51,24 @@
"revId": "c9ed6b72e2a915d79eb06698207986133198bf8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6c236913_db26d0c6",
"filename": "specs/caracal/improve-driver-discovery.rst",
"patchSetId": 1
},
"lineNbr": 89,
"author": {
"id": 14394
},
"writtenOn": "2023-11-17T00:18:57Z",
"side": 1,
"message": "Thanks for the info on `os_distro`. It feels additional to the goal of this proposal, but this is a good time to implement alternative behaviour.\n\nThe priority change for `magnum_driver` suggested wouldn\u0027t require the driver interface `provides` property to change, only the Magnum logic for selection of drivers.\n\nIt sounds like this might match what you are proposing:\n1. Filter all drivers and match on `server_type` and `coe` from driver `provides`.\n2. If `magnum_driver` is provided on the image, use the matching driver or fail if not found. (this allows tie-break use case AND primary selection).\n3. Filter driver list by the `provides` `os` value, using `magnum_distro` value from image (fallback to using `os_distro` from image)\n4. If more than one driver remains, raise Exception.\n\nSo we introduce the two optional image metadata `magnum_distro` and `magnum_driver`, with fallback to existing driver selection behaviour with the addition of an Exception on conflict.\n\nTo me, this sounds viable and would achieve the goals for the change.",
"parentUuid": "6fb372ea_6f04f5c3",
"revId": "c9ed6b72e2a915d79eb06698207986133198bf8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {