Update patch set 1
Patch Set 1: (3 comments) This change is ready for review. Patch-set: 1 CC: Gerrit User 14394 <14394@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Work-in-progress: false Attention: {"person_ident":"Gerrit User 8064 \u003c8064@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14394\u003e replied on the change"}
This commit is contained in:
parent
414be1fa68
commit
f158caf77c
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e0a03c2b_ba0aae73",
|
||||
"filename": "specs/caracal/improve-driver-discovery.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 14394
|
||||
},
|
||||
"writtenOn": "2023-11-15T00:04:22Z",
|
||||
"side": 1,
|
||||
"message": "Suggest \"allows Magnum to select the preferred driver\".\n\nCurrently, Magnum will always pick the second driver added to the driver dictionary (it overwrites the first). So finding a driver isn\u0027t a problem! 😊",
|
||||
"revId": "c9ed6b72e2a915d79eb06698207986133198bf8c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8f2dc02a_d985f708",
|
||||
"filename": "specs/caracal/improve-driver-discovery.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 96,
|
||||
"author": {
|
||||
"id": 14394
|
||||
},
|
||||
"writtenOn": "2023-11-15T00:04:22Z",
|
||||
"side": 1,
|
||||
"message": "Worth noting that this solution is the only one that continues to hide the driver details/naming from the Magnum API. The other solutions all expose the driver existence in some manner.\n\nThe drawbacks mean it\u0027s not viable for a cloud migrating from one driver to another, however.",
|
||||
"revId": "c9ed6b72e2a915d79eb06698207986133198bf8c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "cda2bf88_7e3a1ed3",
|
||||
"filename": "specs/caracal/improve-driver-discovery.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 127,
|
||||
"author": {
|
||||
"id": 14394
|
||||
},
|
||||
"writtenOn": "2023-11-15T00:04:22Z",
|
||||
"side": 1,
|
||||
"message": "I think I know what you\u0027re proposing, but I\u0027m not sure these examples make sense as they use two operating systems in the naming (even though one is also the driver name) ;)",
|
||||
"revId": "c9ed6b72e2a915d79eb06698207986133198bf8c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue