openstack
/
magnum-specs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(9 comments)

Patch-set: 6
CC: Gerrit User 8064 <8064@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 22629 \u003c22629@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8064\u003e replied on the change"}
This commit is contained in:
Gerrit User 8064 2022-10-31 11:28:04 +00:00 committed by Gerrit Code Review
parent f2b6be9986
commit fef0777a1b
1 changed files with 203 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

203
3a6acd08771d3fa5889b54ed7a25978a85cc85e4
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "f8f6a37b_342324b5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "Thanks for putting in so much effort in creating this spec. Michal has a lot of good points, I think fixing up those will tighten this a bit more. I also hope that we can have more clarity on the \"Initial POC\" section.\n\nI think we are on a good track. Looking forward to the updated POC!",
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -23,6 +40,29 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8ca1e3dd_45309fee",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 26,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "particularly",
"range": {
"startLine": 26,
"startChar": 10,
"endLine": 26,
"endChar": 20
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -161,6 +201,30 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6da5efca_901e8116",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 72,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "Long term wise I think it will be fantastic to be able to use an admin level API to bootstrap a management cluster. Whether Heat is used to do it will be a discussion for future, I agree that it is out of scope for first pass.",
"parentUuid": "bb61a452_e7b84ed9",
"range": {
"startLine": 69,
"startChar": 0,
"endLine": 72,
"endChar": 25
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -184,6 +248,53 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c225b44d_82fefb9c",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 87,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "Currently we do support FCOS35",
"parentUuid": "68c407a7_f65223ed",
"range": {
"startLine": 87,
"startChar": 29,
"endLine": 87,
"endChar": 48
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3bd21e9c_d7106f40",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 99,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "This is not really true as it has been bumped recently.\nFor simplicity sake, shall we state this as \u0027Managed in Magnum code\u0027 as that is one of the pain points?",
"range": {
"startLine": 99,
"startChar": 29,
"endLine": 99,
"endChar": 50
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -247,6 +358,52 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1b6cf350_078275a1",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 165,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "I feel like this should be higher up, maybe before supporting resizing? It will give us a good base to work and increase velocity of patches when we have good tests. Is that too difficult?",
"range": {
"startLine": 165,
"startChar": 0,
"endLine": 165,
"endChar": 46
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bfd5b99d_43d83122",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 181,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "I find this part a bit confusing. Will this be updated with the Helm implementation? Can we have an example here?",
"range": {
"startLine": 174,
"startChar": 0,
"endLine": 181,
"endChar": 0
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -408,6 +565,29 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0c048de5_b7f28b88",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 208,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "I am a bit confused by this. \n\nShould the spec only state what is the final design? Discussion about the POC may not be necessary?",
"range": {
"startLine": 208,
"startChar": 0,
"endLine": 208,
"endChar": 58
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -477,6 +657,29 @@
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "75580638_92c971aa",
"filename": "specs/antelope/clusterapi-driver.rst",
"patchSetId": 6
},
"lineNbr": 229,
"author": {
"id": 8064
},
"writtenOn": "2022-10-31T11:28:04Z",
"side": 1,
"message": "I recommend this to say \"Our preference will be to support Application Credentials as a first choice, with the fallback to Trusts if that is not possible.\"",
"range": {
"startLine": 224,
"startChar": 0,
"endLine": 229,
"endChar": 39
},
"revId": "3a6acd08771d3fa5889b54ed7a25978a85cc85e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {