370 lines
18 KiB
Python
370 lines
18 KiB
Python
# Copyright 2015 EasyStack, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
from glanceclient import exc as glance_exception
|
|
from novaclient import exceptions as nova_exc
|
|
from unittest import mock
|
|
|
|
from magnum.api import attr_validator
|
|
from magnum.common import exception
|
|
from magnum.tests import base
|
|
|
|
|
|
class TestAttrValidator(base.BaseTestCase):
|
|
|
|
def test_validate_flavor_with_vaild_flavor(self):
|
|
mock_flavor = mock.MagicMock()
|
|
mock_flavor.name = 'test_flavor'
|
|
mock_flavor.id = 'test_flavor_id'
|
|
mock_flavors = [mock_flavor]
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.flavors.list.return_value = mock_flavors
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
attr_validator.validate_flavor(mock_os_cli, 'test_flavor')
|
|
self.assertTrue(mock_nova.flavors.list.called)
|
|
|
|
def test_validate_flavor_with_none_flavor(self):
|
|
mock_flavor = mock.MagicMock()
|
|
mock_flavor.name = 'test_flavor'
|
|
mock_flavor.id = 'test_flavor_id'
|
|
mock_flavors = [mock_flavor]
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.flavors.list.return_value = mock_flavors
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
attr_validator.validate_flavor(mock_os_cli, None)
|
|
self.assertEqual(False, mock_nova.flavors.list.called)
|
|
|
|
def test_validate_flavor_with_invalid_flavor(self):
|
|
mock_flavor = mock.MagicMock()
|
|
mock_flavor.name = 'test_flavor_not_equal'
|
|
mock_flavor.id = 'test_flavor_id_not_equal'
|
|
mock_flavors = [mock_flavor]
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.flavors.list.return_value = mock_flavors
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
self.assertRaises(exception.FlavorNotFound,
|
|
attr_validator.validate_flavor,
|
|
mock_os_cli, 'test_flavor')
|
|
|
|
def test_validate_external_network_with_valid_network(self):
|
|
mock_networks = {'networks': [{'name': 'test_ext_net',
|
|
'id': 'test_ext_net_id'}]}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
attr_validator.validate_external_network(mock_os_cli, 'test_ext_net')
|
|
self.assertTrue(mock_neutron.list_networks.called)
|
|
|
|
def test_validate_external_network_with_multiple_valid_network(self):
|
|
mock_networks = {'networks':
|
|
[{'name': 'test_ext_net', 'id': 'test_ext_net_id1'},
|
|
{'name': 'test_ext_net', 'id': 'test_ext_net_id2'}]}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.Conflict,
|
|
attr_validator.validate_external_network,
|
|
mock_os_cli, 'test_ext_net')
|
|
|
|
def test_validate_external_network_with_invalid_network(self):
|
|
mock_networks = {'networks': [{'name': 'test_ext_net_not_equal',
|
|
'id': 'test_ext_net_id_not_equal'}]}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.ExternalNetworkNotFound,
|
|
attr_validator.validate_external_network,
|
|
mock_os_cli, 'test_ext_net')
|
|
|
|
def test_validate_fixed_network_with_valid_network(self):
|
|
mock_networks = {'networks': [{'name': 'test_net',
|
|
'id': 'test_net_id'}]}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertEqual('test_net_id',
|
|
attr_validator.validate_fixed_network(mock_os_cli,
|
|
'test_net'))
|
|
self.assertTrue(mock_neutron.list_networks.called)
|
|
|
|
def test_validate_fixed_network_with_multiple_valid_network(self):
|
|
mock_networks = {
|
|
'networks': [{'name': 'test_net',
|
|
'id': 'test_net_id1'},
|
|
{'name': 'test_net',
|
|
'id': 'test_net_id2'}],
|
|
}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.Conflict,
|
|
attr_validator.validate_fixed_network,
|
|
mock_os_cli, 'test_net')
|
|
|
|
def test_validate_fixed_network_with_invalid_network(self):
|
|
mock_networks = {'networks': [{'name': 'test_net_not_equal',
|
|
'id': 'test_net_id_not_equal'}]}
|
|
mock_neutron = mock.MagicMock()
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.FixedNetworkNotFound,
|
|
attr_validator.validate_fixed_network,
|
|
mock_os_cli, 'test_net')
|
|
|
|
def test_validate_fixed_subnet_with_valid_subnet(self):
|
|
mock_neutron = mock.MagicMock()
|
|
mock_subnets = {'subnets': [{'name': 'test_subnet',
|
|
'id': 'test_subnet_id',
|
|
'network_id': 'test_net_id'}]}
|
|
mock_neutron.list_subnets.return_value = mock_subnets
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertEqual('test_subnet_id',
|
|
attr_validator.validate_fixed_subnet(mock_os_cli,
|
|
'test_subnet'))
|
|
mock_neutron.list_subnets.assert_called_with()
|
|
|
|
def test_validate_fixed_subnet_with_invalid_subnet(self):
|
|
mock_neutron = mock.MagicMock()
|
|
mock_subnets = {'subnets': [{'name': 'test_subnet',
|
|
'id': 'test_subnet_id',
|
|
'network_id': 'test_net_id'}]}
|
|
mock_neutron.list_subnets.return_value = mock_subnets
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.FixedSubnetNotFound,
|
|
attr_validator.validate_fixed_subnet,
|
|
mock_os_cli, 'test_subnet_not_found')
|
|
|
|
def test_validate_fixed_subnet_with_multiple_valid_subnet(self):
|
|
mock_neutron = mock.MagicMock()
|
|
mock_subnets = {'subnets': [{'name': 'test_subnet',
|
|
'id': 'test_subnet_id',
|
|
'network_id': 'test_net_id'},
|
|
{'name': 'test_subnet',
|
|
'id': 'test_subnet_id2',
|
|
'network_id': 'test_net_id2'}]}
|
|
mock_neutron.list_subnets.return_value = mock_subnets
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.Conflict,
|
|
attr_validator.validate_fixed_subnet,
|
|
mock_os_cli, 'test_subnet')
|
|
|
|
def test_validate_keypair_with_no_keypair(self):
|
|
mock_keypair = mock.MagicMock()
|
|
mock_keypair.id = None
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.keypairs.get.return_value = mock_keypair
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
attr_validator.validate_keypair(mock_os_cli, None)
|
|
|
|
def test_validate_keypair_with_valid_keypair(self):
|
|
mock_keypair = mock.MagicMock()
|
|
mock_keypair.id = 'test-keypair'
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.keypairs.get.return_value = mock_keypair
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
attr_validator.validate_keypair(mock_os_cli, 'test-keypair')
|
|
|
|
def test_validate_keypair_with_invalid_keypair(self):
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.keypairs.get.side_effect = nova_exc.NotFound('test-keypair')
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
self.assertRaises(exception.KeyPairNotFound,
|
|
attr_validator.validate_keypair,
|
|
mock_os_cli, 'test_keypair')
|
|
|
|
def test_validate_labels_main_no_label(self):
|
|
fake_labels = {}
|
|
attr_validator.validate_labels(fake_labels)
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_valid_image_by_name(self, mock_os_res):
|
|
mock_image = {'name': 'fedora-21-coreos-5',
|
|
'id': 'e33f0988-1730-405e-8401-30cbc8535302',
|
|
'os_distro': 'fedora-coreos'}
|
|
mock_os_res.return_value = mock_image
|
|
mock_os_cli = mock.MagicMock()
|
|
attr_validator.validate_image(mock_os_cli, 'fedora-21-coreos-5')
|
|
self.assertTrue(mock_os_res.called)
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_forbidden_image(self, mock_os_res):
|
|
def glance_side_effect(cli, image, name):
|
|
raise glance_exception.HTTPForbidden()
|
|
|
|
mock_os_res.side_effect = glance_side_effect
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.ImageNotAuthorized,
|
|
attr_validator.validate_image, mock_os_cli,
|
|
'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_valid_image_by_id(self, mock_os_res):
|
|
mock_image = {'name': 'fedora-21-coreos-5',
|
|
'id': 'e33f0988-1730-405e-8401-30cbc8535302',
|
|
'os_distro': 'fedora-coreos'}
|
|
mock_os_res.return_value = mock_image
|
|
mock_os_cli = mock.MagicMock()
|
|
attr_validator.validate_image(mock_os_cli,
|
|
'e33f0988-1730-405e-8401-30cbc8535302')
|
|
self.assertTrue(mock_os_res.called)
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_nonexist_image_by_name(self, mock_os_res):
|
|
mock_os_res.side_effect = exception.ResourceNotFound
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.ImageNotFound,
|
|
attr_validator.validate_image,
|
|
mock_os_cli, 'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_nonexist_image_by_id(self, mock_os_res):
|
|
mock_os_res.side_effect = glance_exception.NotFound
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.ImageNotFound,
|
|
attr_validator.validate_image,
|
|
mock_os_cli, 'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_with_multi_images_same_name(self, mock_os_res):
|
|
mock_os_res.side_effect = exception.Conflict
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.Conflict,
|
|
attr_validator.validate_image,
|
|
mock_os_cli, 'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_without_os_distro(self, mock_os_res):
|
|
mock_image = {'name': 'fedora-21-coreos-5',
|
|
'id': 'e33f0988-1730-405e-8401-30cbc8535302'}
|
|
mock_os_res.return_value = mock_image
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.OSDistroFieldNotFound,
|
|
attr_validator.validate_image,
|
|
mock_os_cli, 'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.api.utils.get_openstack_resource')
|
|
def test_validate_image_when_user_forbidden(self, mock_os_res):
|
|
mock_image = {'name': 'fedora-21-coreos-5',
|
|
'id': 'e33f0988-1730-405e-8401-30cbc8535302',
|
|
'os_distro': ''}
|
|
mock_os_res.return_value = mock_image
|
|
mock_os_cli = mock.MagicMock()
|
|
self.assertRaises(exception.OSDistroFieldNotFound,
|
|
attr_validator.validate_image,
|
|
mock_os_cli, 'fedora-21-coreos-5')
|
|
|
|
@mock.patch('magnum.common.clients.OpenStackClients')
|
|
def test_validate_os_resources_with_invalid_flavor(self,
|
|
mock_os_cli):
|
|
mock_cluster_template = {'flavor_id': 'test_flavor'}
|
|
mock_flavor = mock.MagicMock()
|
|
mock_flavor.name = 'test_flavor_not_equal'
|
|
mock_flavor.id = 'test_flavor_id_not_equal'
|
|
mock_flavors = [mock_flavor]
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.flavors.list.return_value = mock_flavors
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
mock_context = mock.MagicMock()
|
|
self.assertRaises(exception.FlavorNotFound,
|
|
attr_validator.validate_os_resources,
|
|
mock_context, mock_cluster_template)
|
|
|
|
@mock.patch('magnum.common.clients.OpenStackClients')
|
|
@mock.patch('magnum.api.attr_validator.validators')
|
|
def test_validate_os_resources_without_validator(self, mock_validators,
|
|
mock_os_cli):
|
|
mock_cluster_template = {}
|
|
mock_context = mock.MagicMock()
|
|
attr_validator.validate_os_resources(mock_context,
|
|
mock_cluster_template)
|
|
|
|
@mock.patch('magnum.common.clients.OpenStackClients')
|
|
def test_validate_os_resources_with_valid_fixed_subnet(self,
|
|
os_clients_klass):
|
|
mock_cluster_template = {'fixed_network': 'test_net',
|
|
'fixed_subnet': 'test_subnet'}
|
|
mock_context = mock.MagicMock()
|
|
mock_os_cli = mock.MagicMock()
|
|
os_clients_klass.return_value = mock_os_cli
|
|
mock_neutron = mock.MagicMock()
|
|
mock_networks = {'networks': [{'name': 'test_net',
|
|
'id': 'test_net_id'}]}
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_subnets = {'subnets': [{'name': 'test_subnet',
|
|
'id': 'test_subnet_id',
|
|
'network_id': 'test_net_id'}]}
|
|
mock_neutron.list_subnets.return_value = mock_subnets
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
attr_validator.validate_os_resources(mock_context,
|
|
mock_cluster_template)
|
|
|
|
@mock.patch('magnum.common.clients.OpenStackClients')
|
|
def test_validate_os_resources_with_invalid_fixed_subnet(self,
|
|
os_clients_klass):
|
|
mock_cluster_template = {'fixed_network': 'test_net',
|
|
'fixed_subnet': 'test_subnet2'}
|
|
mock_context = mock.MagicMock()
|
|
mock_os_cli = mock.MagicMock()
|
|
os_clients_klass.return_value = mock_os_cli
|
|
mock_neutron = mock.MagicMock()
|
|
mock_networks = {'networks': [{'name': 'test_net',
|
|
'id': 'test_net_id'}]}
|
|
mock_neutron.list_networks.return_value = mock_networks
|
|
mock_subnets = {'subnets': [{'name': 'test_subnet',
|
|
'id': 'test_subnet_id',
|
|
'network_id': 'test_net_id'}]}
|
|
mock_neutron.list_subnets.return_value = mock_subnets
|
|
mock_os_cli.neutron.return_value = mock_neutron
|
|
self.assertRaises(exception.FixedSubnetNotFound,
|
|
attr_validator.validate_os_resources, mock_context,
|
|
mock_cluster_template)
|
|
|
|
@mock.patch('magnum.common.clients.OpenStackClients')
|
|
def test_validate_os_resources_with_cluster(self, mock_os_cli):
|
|
mock_cluster_template = {}
|
|
mock_cluster = {
|
|
'keypair': 'test-keypair', 'labels': {'lab1': 'val1'},
|
|
'image_id': 'e33f0988-1730-405e-8401-30cbc8535302'
|
|
}
|
|
mock_keypair = mock.MagicMock()
|
|
mock_keypair.id = 'test-keypair'
|
|
mock_image = {'name': 'fedora-21-coreos-5',
|
|
'id': 'e33f0988-1730-405e-8401-30cbc8535302',
|
|
'os_distro': 'fedora-coreos'}
|
|
mock_nova = mock.MagicMock()
|
|
mock_nova.keypairs.get.return_value = mock_keypair
|
|
mock_nova.images.get.return_value = mock_image
|
|
mock_os_cli = mock.MagicMock()
|
|
mock_os_cli.nova.return_value = mock_nova
|
|
mock_context = mock.MagicMock()
|
|
attr_validator.validate_os_resources(mock_context,
|
|
mock_cluster_template,
|
|
mock_cluster)
|