From 601b450cf916b0b07fd946a52596ad1b0d65521b Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 12 May 2020 18:45:24 -0500 Subject: [PATCH] Fix hacking min version to 3.0.1 flake8 new release 3.8.0 added new checks and gate pep8 job start failing. hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new version with new checks. Though it is fixed in latest hacking but 2.0 and 3.0 has cap for flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also break the pep8 job if new check are added. To avoid similar gate break in future, we need to bump the hacking min version. Also removing the hacking and other related dep from lower-constraints file as theose are blacklisted requirements and does not need to be present there. - http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html Change-Id: I475765d76453590c47de84809fd51433d4577c76 --- lower-constraints.txt | 4 ---- test-requirements.txt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lower-constraints.txt b/lower-constraints.txt index 3babf3a..e1919da 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -7,8 +7,6 @@ decorator==4.2.1 diskimage-builder==1.1.2 docutils==0.11 dulwich==0.19.0 -flake8==2.5.5 -hacking==0.12.0 idna==2.6 imagesize==1.0.0 Jinja2==2.10 @@ -17,8 +15,6 @@ mccabe==0.2.1 networkx==1.11 openstackdocstheme==1.31.2 pbr==2.0.0 -pep8==1.5.7 -pyflakes==0.8.1 Pygments==2.2.0 pytz==2018.3 PyYAML==3.12 diff --git a/test-requirements.txt b/test-requirements.txt index 0733a62..e12a1a9 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -3,7 +3,7 @@ # process, which may cause wedges in the gate later. bashate>=0.5.1 # Apache-2.0 -hacking>=3.0,<3.1.0 # Apache-2.0 +hacking>=3.0.1,<3.1.0 # Apache-2.0 docutils>=0.11 # OSI-Approved Open Source, Public Domain sphinx!=1.6.6,!=1.6.7,!=2.1.0,>=1.6.2 # BSD