From dc4f811c1a3a9d72f3ceff7d93c85272bdd67e0a Mon Sep 17 00:00:00 2001 From: Jan Provaznik Date: Wed, 3 May 2017 09:12:49 +0000 Subject: [PATCH] Provide filter name in user messages Filtering issues are most common when creating a share. User messages now keep information which was the last executed filter if hosts filtering failed. DocImpact Partially-implements: blueprint user-messages Change-Id: I9ce096eebda3249687268e361b7141dea4032b57 --- manila_tempest_tests/tests/api/admin/test_user_messages.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/manila_tempest_tests/tests/api/admin/test_user_messages.py b/manila_tempest_tests/tests/api/admin/test_user_messages.py index 30e40be8..a8879708 100644 --- a/manila_tempest_tests/tests/api/admin/test_user_messages.py +++ b/manila_tempest_tests/tests/api/admin/test_user_messages.py @@ -87,7 +87,12 @@ class UserMessageTest(base.BaseSharesAdminTest): self.assertEqual(set(MESSAGE_KEYS), set(message.keys())) self.assertTrue(uuidutils.is_uuid_like(message['id'])) self.assertEqual('001', message['action_id']) - self.assertEqual('002', message['detail_id']) + # don't check specific detail_id which may vary + # depending on order of filters, we can still check + # user_message + self.assertIn( + 'No storage could be allocated for this share request', + message['user_message']) self.assertEqual('SHARE', message['resource_type']) self.assertTrue(uuidutils.is_uuid_like(message['resource_id'])) self.assertEqual('ERROR', message['message_level'])