openstack
/
manila
Code Issues Proposed changes

Remove hacking exception for oslo.messaging import 

olso.messaging moved away from namespace packages so this check is no
longer needed.

Change-Id: I76ac67cf38a22350bdb68351f5bb3f38cb9763c5
This commit is contained in:
Thomas Bechtold 2015-03-02 07:58:46 +01:00
parent b76becd303
commit 0eedb98a9a
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila/hacking/checks.py
View File

@ -52,9 +52,7 @@ string_translation = re.compile(r"[^_]*_\(\s*('|\")")
underscore_import_check = re.compile(r"(.)*import _(.)*")
# We need this for cases where they have created their own _ function.
custom_underscore_check = re.compile(r"(.)*_\s*=\s*(.)*")
# TODO(toabctl): Remove the oslo.messaging exception when package
# moved away from namespace
oslo_namespace_imports = re.compile(r"from[\s]*oslo[.](?!messaging)(.*)")
oslo_namespace_imports = re.compile(r"from[\s]*oslo[.](.*)")
class BaseASTChecker(ast.NodeVisitor):

2
manila/test.py
View File

@ -27,11 +27,11 @@ import uuid
import fixtures
import mock
from oslo.messaging import conffixture as messaging_conffixture
from oslo_concurrency import lockutils
from oslo_config import cfg
from oslo_config import fixture as config_fixture
from oslo_log import log
from oslo_messaging import conffixture as messaging_conffixture
import oslotest.base as base_test
import six