openstack
/
manila
Code Issues Proposed changes

TrivialFix: replace set(sorted(x)) with sorted(set(x)) 

This fixes the code committed in commit
abe3224774

set(x) is not expected to preserve ordering and
shouldn't be passed a sorted list to deduplicate.

Change-Id: I8f201657056c73f2ae0aabcc911a1fdca022d881
This commit is contained in:
Goutham Pacha Ravi 2017-07-05 21:39:01 -07:00
parent 54c928c109
commit 194c1152ab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py
View File

@ -356,7 +356,7 @@ class NetAppCmodeMultiSVMFileStorageLibrary(
interfaces_on_vlans.append(interface)
vlans.append(interface['home-port'])
vlans = '-'.join(set(sorted(vlans))) if vlans else None
vlans = '-'.join(sorted(set(vlans))) if vlans else None
@utils.synchronized('netapp-VLANs-%s' % vlans, external=True)
def _delete_vserver_with_lock():