[devstack] Setup a "shared-file-system" service

A few releases ago, service types were standardized
across OpenStack [1] and manila's service type was
recommended as "shared-file-system" [2]. Tools were
meant to look at the service-types-authority [3]
and os-service-types repository [4] to find a list
of standard service type names for various first
party OpenStack services.

The openstacksdk currently relies on the service
type to be "shared-file-system" [5], so let's set
one up in devstack, to aid contributors working on
openstacksdk.

It is desirable to have all clients to initially
look for the standard service type name in the
cloud's service catalog, and fall back to the
legacy name ("sharev2") in environments that
call the v2 API that.

[1] https://specs.openstack.org/openstack/service-types-authority/
[2] https://service-types.openstack.org/service-types.json
[3] https://opendev.org/openstack/service-types-authority
[4] https://opendev.org/openstack/os-service-types
[5] f4dd6fe5fd/openstack/_services_mixin.py (L71-L72)

Change-Id: I6a1ada102a40f3e83fe8e5287856d01dd137ea95
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

devstack/plugin.sh

@@ -500,6 +500,15 @@ function create_manila_accounts {
     Filesystem Service V2 (Legacy 2.0)"
     get_or_create_endpoint "sharev2_legacy" "$REGION_NAME" \
         "$MANILA_ENDPOINT_BASE/v2/\$(project_id)s"
+
+    # Set up an endpoint for "shared-file-system" - this is necessary to
+    # standardize a naming for the v2 API and for the openstacksdk.
+    # See: https://specs.openstack.org/openstack/service-types-authority/
+    get_or_create_service "shared-file-system" "shared-file-system" "Manila
+    Shared Filesystem Service v2 API (alias of the sharev2 service)"
+    get_or_create_endpoint "shared-file-system" "$REGION_NAME" \
+        "$MANILA_ENDPOINT_BASE/v2"
+
 }
 
 # create_default_share_group_type - create share group type that will be set as default.