openstack
/
manila
Code Issues Proposed changes

Merge "Fix wrong assertion methods"

This commit is contained in:
Zuul 2023-02-20 16:06:03 +00:00 committed by Gerrit Code Review
parent 214dc4fb73 adcec06b7b
commit 50e823e643
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/tests/share/drivers/container/test_storage_helper.py
View File

@ -167,7 +167,7 @@ class LVMHelperTestCase(test.TestCase):
self.LVMHelper.rename_storage,
fake_old_share_name, fake_new_share_name)
mock_try_to_umount.assert_called_once_with(fake_old_device)
mock_execute.mock_assert_called_once_with(
mock_execute.assert_called_once_with(
"lvrename", "--autobackup", "n", fake_old_device, fake_new_device,
run_as_root=True
)

6
manila/tests/share/drivers/glusterfs/test_layout_directory.py
View File

@ -249,7 +249,7 @@ class GlusterfsDirectoryMappedLayoutTestCase(test.TestCase):
ret = self._layout.create_share(self._context, self.share, *extra_args)
self._layout._get_local_share_path.called_once_with(self.share)
self._layout._get_local_share_path.assert_called_once_with(self.share)
self._layout.gluster_manager.gluster_call.assert_called_once_with(
'volume', 'quota', 'testvol', 'limit-usage', '/fakename', '1GB')
privsep_os.mkdir.assert_called_once_with(fake_local_share_path)
@ -274,7 +274,7 @@ class GlusterfsDirectoryMappedLayoutTestCase(test.TestCase):
exception.GlusterfsException, self._layout.create_share,
self._context, self.share)
self._layout._get_local_share_path.called_once_with(self.share)
self._layout._get_local_share_path.assert_called_once_with(self.share)
privsep_os.mkdir.assert_called_once_with(fake_local_share_path)
self._layout._cleanup_create_share.assert_called_once_with(
fake_local_share_path, self.share['name'])
@ -300,7 +300,7 @@ class GlusterfsDirectoryMappedLayoutTestCase(test.TestCase):
RuntimeError, self._layout.create_share,
self._context, self.share)
self._layout._get_local_share_path.called_once_with(self.share)
self._layout._get_local_share_path.assert_called_once_with(self.share)
privsep_os.mkdir.assert_called_once_with(fake_local_share_path)
self.assertFalse(self._layout._cleanup_create_share.called)