Don't run periodic_share_replica_update() on active replicas

Similarly to periodic_share_replica_snapshot_update() skip active
replicas and do what the comment above says.

Change-Id: I719c670416c06f8eb9228a3537034285ae3733b4
Partial-Bug: #1924230
This commit is contained in:
Maurice Escher 2021-04-15 10:06:41 +02:00
parent ad4315eb36
commit 5ba3117f20
No known key found for this signature in database
GPG Key ID: CC56DEC23EE46750
2 changed files with 8 additions and 1 deletions

View File

@ -2566,7 +2566,8 @@ class ShareManager(manager.SchedulerDependentManager):
# Filter only non-active replicas belonging to this backend
def qualified_replica(r):
return (share_utils.extract_host(r['host']) ==
share_utils.extract_host(self.host))
share_utils.extract_host(self.host) and
r['replica_state'] != constants.REPLICA_STATE_ACTIVE)
replicas = list(filter(lambda x: qualified_replica(x), replicas))
for replica in replicas:

View File

@ -0,0 +1,6 @@
---
fixes:
- Fixed periodic_share_replica_update() to skip active replicas similarly to
periodic_share_replica_snapshot_update(). The intention is to check on
non-active replicas, that can be 'in_sync', 'out_of_sync' or in 'error'
state.