From 674c9c9e19937fa741d70dca0e92cbbf428ee1f2 Mon Sep 17 00:00:00 2001 From: Elvis Acheampong Date: Tue, 26 Mar 2024 19:00:05 +0000 Subject: [PATCH] Adds "usedforsecurity=False" to veritas drivers The purpose of md5 was not specified. Veritas drivers use mds hashes which pop on bandit as security issues Putting "usedforsecurity=False" properly shows the hash function is not use for security. Change-Id: I78a5b708cd970dcb60f480d8e6a201d0768645fc --- manila/share/drivers/veritas/veritas_isa.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/manila/share/drivers/veritas/veritas_isa.py b/manila/share/drivers/veritas/veritas_isa.py index 8483235dff..9a322f9594 100644 --- a/manila/share/drivers/veritas/veritas_isa.py +++ b/manila/share/drivers/veritas/veritas_isa.py @@ -141,8 +141,10 @@ class ACCESSShareDriver(driver.ExecuteMixin, driver.ShareDriver): index = int(length / 2) name1 = name[:index] name2 = name[index:] - crc1 = hashlib.md5(name1.encode('utf-8')).hexdigest()[:8] - crc2 = hashlib.md5(name2.encode('utf-8')).hexdigest()[:8] + crc1 = hashlib.md5(name1.encode('utf-8'), + usedforsecurity=False).hexdigest()[:8] + crc2 = hashlib.md5(name2.encode('utf-8'), + usedforsecurity=False).hexdigest()[:8] return crc1 + '-' + crc2 def _get_va_snap_name(self, name):