openstack
/
manila
Code Issues Proposed changes

HPE3PAR create share from snapshot fails 

HPE3PAR create share from snapshot fails with
ShareSnapshotInstance has no attribute 'share'.

Change-Id: I74d2f90aae4ad222d2dc919b483a483d15b02e69
Closes-Bug: #1519066
(cherry picked from commit 9f98fe2a2c)
This commit is contained in:
mark.sturdevant 2015-11-23 11:53:08 -08:00
parent e86be04243
commit 8029061c3d
5 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
manila/share/drivers/hp/hp_3par_driver.py
View File

@ -286,9 +286,8 @@ class HP3ParShareDriver(driver.ShareDriver):
share['id'],
protocol,
extra_specs,
snapshot['share']['project_id'],
snapshot['share']['id'],
snapshot['share']['share_proto'],
share['project_id'],
snapshot['share_id'],
snapshot['id'],
self.fpg,
self.vfs,

4
manila/share/drivers/hp/hp_3par_mediator.py
View File

@ -469,7 +469,7 @@ class HP3ParMediator(object):
return result['members'][0]['shareName']
def create_share_from_snapshot(self, share_id, share_proto, extra_specs,
orig_project_id, orig_share_id, orig_proto,
orig_project_id, orig_share_id,
snapshot_id, fpg, vfs,
comment=OPEN_STACK_MANILA):
@ -479,7 +479,7 @@ class HP3ParMediator(object):
snapshot = self._find_fsnap(orig_project_id,
orig_share_name,
orig_proto,
protocol,
snapshot_tag,
fpg,
vfs)

7
manila/tests/share/drivers/hp/test_hp_3par_constants.py
View File

@ -92,6 +92,13 @@ SNAPSHOT_INFO = {
},
}
SNAPSHOT_INSTANCE = {
'name': EXPECTED_SNAP_NAME,
'id': EXPECTED_SNAP_ID,
'share_id': EXPECTED_SHARE_ID,
'share_proto': NFS,
}
class FakeException(Exception):
pass

14
manila/tests/share/drivers/hp/test_hp_3par_driver.py
View File

@ -185,7 +185,7 @@ class HP3ParDriverTestCase(test.TestCase):
def do_create_share_from_snapshot(self,
protocol,
share_type_id,
snapshot_id,
snapshot_instance,
expected_share_id,
expected_size):
"""Re-usable code for create share from snapshot."""
@ -196,6 +196,7 @@ class HP3ParDriverTestCase(test.TestCase):
},
}
share = {
'project_id': constants.EXPECTED_PROJECT_ID,
'display_name': constants.EXPECTED_SHARE_NAME,
'host': constants.EXPECTED_HOST,
'id': expected_share_id,
@ -205,7 +206,7 @@ class HP3ParDriverTestCase(test.TestCase):
}
location = self.driver.create_share_from_snapshot(context,
share,
snapshot_id,
snapshot_instance,
share_server)
return location
@ -301,10 +302,13 @@ class HP3ParDriverTestCase(test.TestCase):
self.mock_mediator.create_share_from_snapshot.return_value = (
constants.EXPECTED_SHARE_NAME)
snapshot_instance = constants.SNAPSHOT_INSTANCE.copy()
snapshot_instance['protocol'] = constants.CIFS
location = self.do_create_share_from_snapshot(
constants.CIFS,
constants.SHARE_TYPE_ID,
constants.SNAPSHOT_INFO,
snapshot_instance,
constants.EXPECTED_SHARE_ID,
constants.EXPECTED_SIZE_2)
@ -316,7 +320,6 @@ class HP3ParDriverTestCase(test.TestCase):
constants.EXPECTED_EXTRA_SPECS,
constants.EXPECTED_FSTORE,
constants.EXPECTED_SHARE_ID,
constants.NFS,
constants.EXPECTED_SNAP_ID,
constants.EXPECTED_FPG,
constants.EXPECTED_VFS,
@ -336,7 +339,7 @@ class HP3ParDriverTestCase(test.TestCase):
location = self.do_create_share_from_snapshot(
constants.NFS,
constants.SHARE_TYPE_ID,
constants.SNAPSHOT_INFO,
constants.SNAPSHOT_INSTANCE,
constants.EXPECTED_SHARE_ID,
constants.EXPECTED_SIZE_1)
@ -348,7 +351,6 @@ class HP3ParDriverTestCase(test.TestCase):
constants.EXPECTED_EXTRA_SPECS,
constants.EXPECTED_PROJECT_ID,
constants.EXPECTED_SHARE_ID,
constants.NFS,
constants.EXPECTED_SNAP_ID,
constants.EXPECTED_FPG,
constants.EXPECTED_VFS,

3
manila/tests/share/drivers/hp/test_hp_3par_mediator.py
View File

@ -483,7 +483,6 @@ class HP3ParMediatorTestCase(test.TestCase):
constants.EXPECTED_EXTRA_SPECS,
constants.EXPECTED_PROJECT_ID,
constants.EXPECTED_SHARE_ID,
constants.NFS,
constants.EXPECTED_SNAP_ID,
constants.EXPECTED_FPG,
constants.EXPECTED_VFS)
@ -530,7 +529,6 @@ class HP3ParMediatorTestCase(test.TestCase):
constants.EXPECTED_EXTRA_SPECS,
constants.EXPECTED_PROJECT_ID,
constants.EXPECTED_SHARE_ID,
constants.NFS,
constants.EXPECTED_SNAP_ID,
constants.EXPECTED_FPG,
constants.EXPECTED_VFS)
@ -578,7 +576,6 @@ class HP3ParMediatorTestCase(test.TestCase):
constants.EXPECTED_EXTRA_SPECS,
constants.EXPECTED_PROJECT_ID,
constants.EXPECTED_SHARE_ID,
constants.NFS,
constants.EXPECTED_SNAP_ID,
constants.EXPECTED_FPG,
constants.EXPECTED_VFS)