From 9da534344a9b8790c88378816db1c1fc378b2a59 Mon Sep 17 00:00:00 2001 From: "Saju.Madhavan" Date: Thu, 26 Jul 2018 02:46:17 +0530 Subject: [PATCH] Fix mutable config in manila-scheduler We had SIGHUP apply the "mutate" behavior to the ProcessLauncher with [1], however, the scheduler process does not use ProcessLauncher. Oslo config made "debug" a mutable config option in [3] Closes-Bug: #1785129 [1] I6499ae6c98d9489a123bb20febd6c1ddb9e17b86 [3] I1e7a69de169cc85f4c09954b2f46ce2da7106d90 Change-Id: Ifffe3cad0f5cd52988ce253794efc5b03ea9840b --- manila/service.py | 3 ++- ...-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/bug-1785129-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml diff --git a/manila/service.py b/manila/service.py index 633631f4e5..4ebffc60d2 100644 --- a/manila/service.py +++ b/manila/service.py @@ -383,7 +383,8 @@ def serve(server, workers=None): global _launcher if _launcher: raise RuntimeError('serve() can only be called once') - _launcher = service.launch(CONF, server, workers=workers) + _launcher = service.launch(CONF, server, workers=workers, + restart_method='mutate') def wait(): diff --git a/releasenotes/notes/bug-1785129-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml b/releasenotes/notes/bug-1785129-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml new file mode 100644 index 0000000000..28f602bdcc --- /dev/null +++ b/releasenotes/notes/bug-1785129-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - The SIGHUP behavior for the manila-scheduler service has been fixed. + Previously, only the manila-share service was responding to SIGHUP and + reloading its configuration, now manila-scheduler does the same. \ No newline at end of file