From f8b962b9c83499d9619a67d5092f35f1283cfb00 Mon Sep 17 00:00:00 2001 From: Li Wei Date: Fri, 28 Oct 2016 15:07:08 +0800 Subject: [PATCH] Correct the order of parameters in assertEqual() The order of parameters should be assertEqual(expected, actual). Change-Id: I0815b1d76fd1f8a90ad3d5f08d70fc5cc4e5d7b7 --- manila/tests/data/test_utils.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/manila/tests/data/test_utils.py b/manila/tests/data/test_utils.py index 27e7645c76..8fea9cca33 100644 --- a/manila/tests/data/test_utils.py +++ b/manila/tests/data/test_utils.py @@ -116,7 +116,7 @@ class CopyClassTestCase(test.TestCase): self._copy.cancel() # asserts - self.assertEqual(self._copy.cancelled, True) + self.assertTrue(self._copy.cancelled) # reset self._copy.cancelled = False @@ -139,7 +139,7 @@ class CopyClassTestCase(test.TestCase): self._copy.get_total_size(self._copy.src) # asserts - self.assertEqual(self._copy.total_size, 10000) + self.assertEqual(10000, self._copy.total_size) utils.execute.assert_has_calls([ mock.call("ls", "-pA1", "--group-directories-first", @@ -159,7 +159,7 @@ class CopyClassTestCase(test.TestCase): self._copy.get_total_size(self._copy.src) # asserts - self.assertEqual(self._copy.total_size, 0) + self.assertEqual(0, self._copy.total_size) # reset self._copy.total_size = 10000 @@ -180,7 +180,7 @@ class CopyClassTestCase(test.TestCase): self._copy.get_total_size(self._copy.src) # asserts - self.assertEqual(self._copy.total_size, 0) + self.assertEqual(0, self._copy.total_size) utils.execute.assert_called_once_with( "ls", "-pA1", "--group-directories-first", self._copy.src, run_as_root=True)