openstack
/
masakari
Code Issues Proposed changes

Merge "Replace getargspec with getfullargspec"

This commit is contained in:
Zuul 2021-05-17 14:24:52 +00:00 committed by Gerrit Code Review
parent 15aef6e0f8 563049ebd4
commit 2c6e500dc1
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
masakari/tests/unit/objects/test_objects.py
View File

@ -832,9 +832,9 @@ class TestObjEqualPrims(_BaseTestCase):
class TestObjMethodOverrides(test.NoDBTestCase):
def test_obj_reset_changes(self):
args = inspect.getargspec(base.MasakariObject.obj_reset_changes)
args = inspect.getfullargspec(base.MasakariObject.obj_reset_changes)
obj_classes = base.MasakariObjectRegistry.obj_classes()
for obj_name in obj_classes:
obj_class = obj_classes[obj_name][0]
self.assertEqual(args,
inspect.getargspec(obj_class.obj_reset_changes))
inspect.getfullargspec(obj_class.obj_reset_changes))

2
masakari/utils.py
View File

@ -137,7 +137,7 @@ def expects_func_args(*args):
@functools.wraps(dec)
def _decorator(f):
base_f = safe_utils.get_wrapped_function(f)
arg_names, a, kw, _default = inspect.getargspec(base_f)
arg_names, a, kw, _, _, _, _ = inspect.getfullargspec(base_f)
if a or kw or set(args) <= set(arg_names):
# NOTE : We can't really tell if correct stuff will
# be passed if it's a function with *args or **kwargs so