openstack
/
mistral
Code Issues Proposed changes

Fix tools/get_action_list.py 

This patch does several things:

 -fixes an issue where trove_base now uses the Manager class
  instead of HookableMixin. This would actually prevent
  tools/get_action_list.py from running any service...
  not just trove.

 -adds 'trove' to the list of supported services by
  using CLIENTS.keys() instead of the inline list
  where 'trove' was previously missing

 -The trove Client class now requires to arguments.

With these options I am again able to use get_action_list.py.

NOTE: The critical error here was actually the HookableMixin
exception in that it prevents you from using this tool with
other services.

Change-Id: I3207e1379101757b282260949a48d22fe193fe85
Closes-bug: #1521740
This commit is contained in:
Dan Prince 2015-12-01 14:51:17 -05:00
parent 75f38d1e3c
commit d9736d2881
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/get_action_list.py
View File

@ -61,7 +61,7 @@ BASE_HEAT_MANAGER = heat_base.HookableMixin
BASE_NOVA_MANAGER = nova_base.HookableMixin
BASE_KEYSTONE_MANAGER = keystone_base.Manager
BASE_CINDER_MANAGER = cinder_base.HookableMixin
BASE_TROVE_MANAGER = trove_base.HookableMixin
BASE_TROVE_MANAGER = trove_base.Manager
def get_parser():
parser = argparse.ArgumentParser(
@ -70,7 +70,7 @@ def get_parser():
)
parser.add_argument(
'service',
choices=['nova', 'glance', 'heat', 'cinder', 'keystone', 'ceilometer'],
choices=CLIENTS.keys(),
help='Service name which methods need to be found.'
)
parser.add_argument(
@ -136,7 +136,7 @@ def get_cinder_client(**kwargs):
return cinderclient.Client()
def get_trove_client(**kwargs):
return troveclient.Client()
return troveclient.Client('username', 'password')
CLIENTS = {
'nova': get_nova_client,