openstack
/
mistral
Code Issues Proposed changes

Wrong handling of is_system flag at workbooks causes DB error with MySQL 5.7 

If we leave is_system workbook attribute as undefined (Null) that causes
database insert error in MySQL 5.7, due to database constraints.
So let's use constant False as is_system attribute in workbook create.
It is OK, because there is no system workbook support in mistral yet.

Change-Id: Idabf9d04d105c2386b9b110f1bbab3e69502b8e0
Closes-Bug: #1733501
This commit is contained in:
Istvan Imre 2017-11-24 14:47:25 +01:00
parent bec878eb89
commit f254c39257
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mistral/services/workbooks.py
View File

@ -100,7 +100,8 @@ def _create_or_update_workflows(wb_db, workflows_spec):
'scope': wb_db.scope,
'project_id': wb_db.project_id,
'namespace': '',
'tags': wf_spec.get_tags()
'tags': wf_spec.get_tags(),
'is_system': False
}
db_wfs.append(
@ -116,7 +117,8 @@ def _get_workbook_values(wb_spec, definition, scope):
'tags': wb_spec.get_tags(),
'definition': definition,
'spec': wb_spec.to_dict(),
'scope': scope
'scope': scope,
'is_system': False
}
return values