openstack
/
monasca-api
Code Issues Proposed changes

Actions enabled return bool on alarm definition create 

Spec is supposed to be a boolean and current code
has it as a string

Fixed unit tests

Change-Id: Id790dca53af161df40e770322b3af3270264199a
This commit is contained in:
mhoppal 2017-06-02 14:57:55 -06:00 committed by Joe Keen
parent 0a3c219a5c
commit c26e674cb5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monasca_api/tests/test_alarms.py
View File

@ -238,7 +238,7 @@ class TestAlarmDefinition(AlarmTestBase):
u'description': u'',
u'match_by': [],
u'name': u'Test Definition',
u'actions_enabled': u'true',
u'actions_enabled': True,
u'undetermined_actions': [],
u'expression': u'test.metric > 10',
u'deterministic': False,
@ -291,7 +291,7 @@ class TestAlarmDefinition(AlarmTestBase):
u'description': u'',
u'match_by': [],
u'name': u'Test Definition',
u'actions_enabled': u'true',
u'actions_enabled': True,
u'undetermined_actions': [],
u'expression': u'test.metric > 10',
u'deterministic': False,

2
monasca_api/v2/reference/alarm_definitions.py
View File

@ -522,7 +522,7 @@ class AlarmDefinitions(alarm_definitions_api_v2.AlarmDefinitionsV2API,
result = (
{u'alarm_actions': alarm_actions, u'ok_actions': ok_actions,
u'description': description, u'match_by': match_by,
u'severity': severity, u'actions_enabled': u'true',
u'severity': severity, u'actions_enabled': True,
u'undetermined_actions': undetermined_actions,
u'expression': expression, u'id': alarm_definition_id,
u'deterministic': is_definition_deterministic(expression),