openstack
/
murano-dashboard
Code Issues Proposed changes

Update patch set 13 

Abandoned

Murano project has been retired https://review.opendev.org/c/openstack/governance/+/919358

Patch-set: 13
Status: abandoned
Tag: autogenerated:gerrit:abandon
This commit is contained in:
Gerrit User 8556 2024-05-15 03:32:40 +00:00 committed by Gerrit Code Review
parent e3d9fa99c2
commit c27e8e93be
1 changed files with 107 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

137
b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3
View File

@ -1,6 +1,7 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_8e3ea5be",
"filename": "muranodashboard/api/rest/hostname.py",
@ -14,10 +15,10 @@
"side": 1,
"message": "I\u0027d rather use smth less generic, e.g. check_murano_hostname? maybe /murano/check/hostname to avoid possible collisions",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_2e2fb988",
"filename": "muranodashboard/api/rest/hostname.py",
@ -37,10 +38,10 @@
"endChar": 64
},
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_ce070d18",
"filename": "muranodashboard/api/rest/hostname.py",
@ -54,10 +55,10 @@
"side": 1,
"message": "why return status as JSON field and not as a HTTP rewsponse field?",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_eea091f6",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -77,10 +78,10 @@
"endChar": 15
},
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_ee52d112",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -94,10 +95,10 @@
"side": 1,
"message": "this looks unrelated to the patch. Can we split it into a separate one?",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_ce55cdfb",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -111,10 +112,10 @@
"side": 1,
"message": "looks like a debugging leftover",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_0e875564",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -134,10 +135,10 @@
"endChar": 37
},
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_4e90bd95",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -157,10 +158,10 @@
"endChar": 31
},
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_ae7f2964",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -174,10 +175,10 @@
"side": 1,
"message": "please move it out of the function",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_4e49dd5d",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -191,10 +192,10 @@
"side": 1,
"message": "please remove",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_8edfc567",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -208,10 +209,10 @@
"side": 1,
"message": "so you\u0027re fetching ALL the servers from nova here, right? That seems like an overkill. After all you can have multiple instances with the same name in nova",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_0e799592",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -225,10 +226,10 @@
"side": 1,
"message": "let\u0027s combine the two. otherwise log messages would be cluttered",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_ce6eedc7",
"filename": "muranodashboard/dynamic_ui/fields.py",
@ -242,10 +243,10 @@
"side": 1,
"message": "ditto",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_cb5a5f81",
"filename": "muranodashboard/static/muranodashboard/js/hostnamefield.js",
@ -265,10 +266,10 @@
"endChar": 39
},
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff346bd7_0e2bd582",
"filename": "muranodashboard/static/muranodashboard/js/hostnamefield.js",
@ -282,8 +283,84 @@
"side": 1,
"message": "why do you check this here and not in the check/hostname code?",
"revId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Code reviewed by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Verified in gate by CI"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Workflow",
"description": {
"value": "Approved for gate by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MIN"],"failingAtoms":["label:Workflow=MAX"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "b77ab8595dcff8e54cd7c713d39aed4e6e9a3fc3",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}