openstack
/
neutron-dynamic-routing
Code Issues Proposed changes

Remove unhelpful test of oslo.service ServiceLauncher 

Similar to what has been done in [1], we should not test functionality
that is internal to oslo.service, so remove the corresponding test.

[1] https://review.openstack.org/316331

Change-Id: I2daa1d67a8a0dbe1f1ef5af333746b23e9edc3bb
This commit is contained in:
Jens Rosenboom 2016-07-11 11:31:18 +02:00
parent 7607f0eb94
commit 9e0819f2d0
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
neutron_dynamic_routing/tests/unit/services/bgp/agent/test_bgp_dragent.py
View File

@ -29,7 +29,6 @@ from neutron.tests import base
from neutron_dynamic_routing.services.bgp.agent import bgp_dragent
from neutron_dynamic_routing.services.bgp.agent import config as bgp_config
from neutron_dynamic_routing.services.bgp.agent import entry
HOSTNAME = 'hostname'
rpc_api = bgp_dragent.BgpDrPluginApi
@ -98,26 +97,6 @@ class TestBgpDrAgent(base.BaseTestCase):
mock.call().report_state(mock.ANY, mock.ANY,
mock.ANY)])
def test_bgp_dragent_main_agent_manager(self):
logging_str = 'neutron.agent.common.config.setup_logging'
launcher_str = 'oslo_service.service.ServiceLauncher'
with mock.patch(logging_str):
with mock.patch.object(sys, 'argv') as sys_argv:
with mock.patch(launcher_str) as launcher:
sys_argv.return_value = ['bgp_dragent', '--config-file',
base.etcdir('neutron.conf')]
entry.main()
if launcher.mock_calls[0][2]:
launcher.assert_has_calls(
[mock.call(cfg.CONF, restart_method='reload'),
mock.call().launch_service(mock.ANY, workers=1),
mock.call().wait()])
else:
launcher.assert_has_calls(
[mock.call(cfg.CONF),
mock.call().launch_service(mock.ANY),
mock.call().wait()])
def test_run_completes_single_pass(self):
bgp_dr = bgp_dragent.BgpDrAgent(HOSTNAME)
with mock.patch.object(bgp_dr, 'sync_state') as sync_state: