From 9aef6c4e038c82b00ccaa70c6d15196c98d8d0b8 Mon Sep 17 00:00:00 2001 From: elajkat Date: Fri, 24 Feb 2023 17:02:17 +0100 Subject: [PATCH] [sqlalchemy-20] The Connection.connect() method is considered legacy Change-Id: I5eaf60426e10c15ac16800ce1962d6690ff80f92 Related-Bug: #2008227 --- .../expand/876782258a43_create_default_firewall_groups_table.py | 2 +- .../f24e0d5e5bff_uniq_firewallgroupportassociation0port.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/876782258a43_create_default_firewall_groups_table.py b/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/876782258a43_create_default_firewall_groups_table.py index e8f4f7786..ae57f5e24 100644 --- a/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/876782258a43_create_default_firewall_groups_table.py +++ b/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/876782258a43_create_default_firewall_groups_table.py @@ -60,7 +60,7 @@ def check_sanity(connection): insp = sa.engine.reflection.Inspector.from_engine(connection) if 'firewall_groups_v2' not in insp.get_table_names(): return [] - session = sa.orm.Session(bind=connection.connect()) + session = sa.orm.Session(bind=connection) default_fwg = session.query(resources.FIREWALL_GROUP.name).filter( resources.FIREWALL_GROUP.name == const.DEFAULT_FWG).first() if default_fwg: diff --git a/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/f24e0d5e5bff_uniq_firewallgroupportassociation0port.py b/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/f24e0d5e5bff_uniq_firewallgroupportassociation0port.py index e4f084445..418f2762a 100644 --- a/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/f24e0d5e5bff_uniq_firewallgroupportassociation0port.py +++ b/neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/f24e0d5e5bff_uniq_firewallgroupportassociation0port.py @@ -64,7 +64,7 @@ def get_duplicate_port_records_in_fwg_port_association(connection): insp = sa.engine.reflection.Inspector.from_engine(connection) if 'firewall_group_port_associations_v2' not in insp.get_table_names(): return [] - session = sa.orm.Session(bind=connection.connect()) + session = sa.orm.Session(bind=connection) query = (session.query(fwg_port_association.c.port_id) .group_by(fwg_port_association.c.port_id) .having(sa.func.count() > 1)).all()