neutron-fwaas/tools
Adit Sarfaty 1d884eab72 Fix pep8 new warnings and pip install error
This patch is a squash of two fix that are needed together to have a
successful zuul run.

1. pep8 fix (cherry-picked from master:
   87eb1b15be )

A recent change in pep/pycodingchecks introduced new warnings as part of
the pep8 target that causes pep8 to fail now.

This patch fixes code that issued warnings W503,E731,E266,E402

In addition, old tests which were not ran anyway, and are no longer
relevant (test_firewall) were deleted.

Conflicts:
	neutron_fwaas/tests/tempest_plugin/tests/scenario/manager.py

2. Avoid parameterless pip install

build-openstack-sphinx-docs jobs fail on all stable branches due to the
new pip version 10 introduces some previously Warning as Error: in case
of calling "pip install" without any package name, the command fails.
tox_install.sh is called during docs job without any package passed to
pip.

This patch also disables E402 hacking check because releasenotes/* violates it
(the issue is not present in Queens+ where
Ib19f7ea4ea136180f38bc78389f51b6b5d179ab8 is merged).

Conflicts:
      neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/876782258a43_create_default_firewall_groups_table.py
      neutron_fwaas/db/migration/alembic_migrations/versions/queens/expand/f24e0d5e5bff_uniq_firewallgroupportassociation0port.py
      neutron_fwaas/services/firewall/fwaas_plugin_v2.py

Change-Id: If893cf2bc136d09e09344a81fd996ac89479a135
(cherry picked from commit 58a62382e9)
2018-04-30 17:08:14 +00:00
..
check_unit_test_structure.sh Update policy.json for FWaaS v2 2017-01-26 15:40:36 +09:00
clean.sh FWaaS: Remove check for bash usage 2015-04-14 08:37:02 -04:00
configure_for_fwaas_func_testing.sh Enable to run rootwrap/privsep related functional tests 2017-02-28 10:18:03 +07:00
deploy_rootwrap.sh Enable to run rootwrap/privsep related functional tests 2017-02-28 10:18:03 +07:00
generate_config_file_samples.sh Automatically generate neutron FWaaS configuration files 2015-12-07 10:50:11 +00:00
ostestr_compat_shim.sh Fix periodic-neutron-fwaas-pyXX-with-neutron-lib-master jobs 2016-09-30 20:57:06 +00:00
tox_install.sh Fix pep8 new warnings and pip install error 2018-04-30 17:08:14 +00:00