From 35e0d8069138a6642f80dbb92d5486195f364477 Mon Sep 17 00:00:00 2001 From: Gary Kotton Date: Wed, 6 Aug 2014 08:19:54 -0700 Subject: [PATCH] Remove @author(s) from copyright statements We have git to track authorship, so let's not pad source files with it as well. A hacking check has been added for this. The value is N322. Change-Id: Iab0b64d417e0bb41a6b455e2ac377deee64ec3ee --- HACKING.rst | 2 ++ neutron/services/loadbalancer/agent/agent.py | 2 -- neutron/services/loadbalancer/agent/agent_api.py | 2 -- neutron/services/loadbalancer/agent/agent_manager.py | 2 -- neutron/services/loadbalancer/drivers/__init__.py | 2 -- neutron/services/loadbalancer/drivers/abstract_driver.py | 2 -- .../services/loadbalancer/drivers/common/agent_driver_base.py | 2 -- .../services/loadbalancer/drivers/embrane/agent/dispatcher.py | 2 -- .../loadbalancer/drivers/embrane/agent/lb_operations.py | 2 -- neutron/services/loadbalancer/drivers/embrane/config.py | 2 -- neutron/services/loadbalancer/drivers/embrane/constants.py | 2 -- neutron/services/loadbalancer/drivers/embrane/db.py | 2 -- neutron/services/loadbalancer/drivers/embrane/driver.py | 2 -- neutron/services/loadbalancer/drivers/embrane/models.py | 2 -- neutron/services/loadbalancer/drivers/embrane/poller.py | 2 -- neutron/services/loadbalancer/drivers/haproxy/__init__.py | 2 -- neutron/services/loadbalancer/drivers/haproxy/cfg.py | 2 -- .../services/loadbalancer/drivers/haproxy/namespace_driver.py | 3 +-- neutron/services/loadbalancer/drivers/radware/__init__.py | 2 -- neutron/services/loadbalancer/drivers/radware/driver.py | 2 -- neutron/services/loadbalancer/drivers/radware/exceptions.py | 2 -- neutron/services/loadbalancer/plugin.py | 2 -- neutron/tests/unit/services/__init__.py | 2 -- neutron/tests/unit/services/loadbalancer/__init__.py | 2 -- neutron/tests/unit/services/loadbalancer/agent/test_agent.py | 2 -- .../unit/services/loadbalancer/agent/test_agent_manager.py | 2 -- neutron/tests/unit/services/loadbalancer/agent/test_api.py | 2 -- neutron/tests/unit/services/loadbalancer/drivers/__init__.py | 2 -- .../loadbalancer/drivers/embrane/test_embrane_defaults.py | 2 -- .../loadbalancer/drivers/embrane/test_plugin_driver.py | 2 -- .../unit/services/loadbalancer/drivers/haproxy/__init__.py | 2 -- .../unit/services/loadbalancer/drivers/haproxy/test_cfg.py | 2 -- .../loadbalancer/drivers/haproxy/test_namespace_driver.py | 2 -- .../unit/services/loadbalancer/drivers/radware/__init__.py | 2 -- .../loadbalancer/drivers/radware/test_plugin_driver.py | 2 -- .../services/loadbalancer/drivers/test_agent_driver_base.py | 2 -- 36 files changed, 3 insertions(+), 70 deletions(-) diff --git a/HACKING.rst b/HACKING.rst index 0f3666fc0..a0595952c 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -10,6 +10,8 @@ Neutron Specific Commandments - [N320] Validate that LOG messages, except debug ones, have translations - [N321] Validate that jsonutils module is used instead of json +- [N322] We do not use @authors tags in source files. We have git to track + authorship. Creating Unit Tests ------------------- diff --git a/neutron/services/loadbalancer/agent/agent.py b/neutron/services/loadbalancer/agent/agent.py index c6e4f68bc..bc7bfe24c 100644 --- a/neutron/services/loadbalancer/agent/agent.py +++ b/neutron/services/loadbalancer/agent/agent.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import sys diff --git a/neutron/services/loadbalancer/agent/agent_api.py b/neutron/services/loadbalancer/agent/agent_api.py index 219c0a226..e62c8b85e 100644 --- a/neutron/services/loadbalancer/agent/agent_api.py +++ b/neutron/services/loadbalancer/agent/agent_api.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost from neutron.common import rpc as n_rpc diff --git a/neutron/services/loadbalancer/agent/agent_manager.py b/neutron/services/loadbalancer/agent/agent_manager.py index 52da4f5ee..d4f7381bd 100644 --- a/neutron/services/loadbalancer/agent/agent_manager.py +++ b/neutron/services/loadbalancer/agent/agent_manager.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost from oslo.config import cfg diff --git a/neutron/services/loadbalancer/drivers/__init__.py b/neutron/services/loadbalancer/drivers/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/services/loadbalancer/drivers/__init__.py +++ b/neutron/services/loadbalancer/drivers/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/services/loadbalancer/drivers/abstract_driver.py b/neutron/services/loadbalancer/drivers/abstract_driver.py index 64854fe43..c56fcac2b 100644 --- a/neutron/services/loadbalancer/drivers/abstract_driver.py +++ b/neutron/services/loadbalancer/drivers/abstract_driver.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware import abc diff --git a/neutron/services/loadbalancer/drivers/common/agent_driver_base.py b/neutron/services/loadbalancer/drivers/common/agent_driver_base.py index 0f8e036d1..e0918497a 100644 --- a/neutron/services/loadbalancer/drivers/common/agent_driver_base.py +++ b/neutron/services/loadbalancer/drivers/common/agent_driver_base.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import uuid diff --git a/neutron/services/loadbalancer/drivers/embrane/agent/dispatcher.py b/neutron/services/loadbalancer/drivers/embrane/agent/dispatcher.py index 7ba000599..2b583bcbd 100644 --- a/neutron/services/loadbalancer/drivers/embrane/agent/dispatcher.py +++ b/neutron/services/loadbalancer/drivers/embrane/agent/dispatcher.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from eventlet import greenthread from eventlet import queue diff --git a/neutron/services/loadbalancer/drivers/embrane/agent/lb_operations.py b/neutron/services/loadbalancer/drivers/embrane/agent/lb_operations.py index f31caf777..f7bc363c9 100644 --- a/neutron/services/loadbalancer/drivers/embrane/agent/lb_operations.py +++ b/neutron/services/loadbalancer/drivers/embrane/agent/lb_operations.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com import functools diff --git a/neutron/services/loadbalancer/drivers/embrane/config.py b/neutron/services/loadbalancer/drivers/embrane/config.py index cac9a63d5..8a5b2ba1f 100644 --- a/neutron/services/loadbalancer/drivers/embrane/config.py +++ b/neutron/services/loadbalancer/drivers/embrane/config.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from oslo.config import cfg diff --git a/neutron/services/loadbalancer/drivers/embrane/constants.py b/neutron/services/loadbalancer/drivers/embrane/constants.py index 61e609598..3d05c520f 100644 --- a/neutron/services/loadbalancer/drivers/embrane/constants.py +++ b/neutron/services/loadbalancer/drivers/embrane/constants.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from heleosapi import constants as h_con from heleosapi import exceptions as h_exc diff --git a/neutron/services/loadbalancer/drivers/embrane/db.py b/neutron/services/loadbalancer/drivers/embrane/db.py index 2e5c9e1d9..ef6928a34 100644 --- a/neutron/services/loadbalancer/drivers/embrane/db.py +++ b/neutron/services/loadbalancer/drivers/embrane/db.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from neutron.db import models_v2 as nmodel from neutron.services.loadbalancer.drivers.embrane import models diff --git a/neutron/services/loadbalancer/drivers/embrane/driver.py b/neutron/services/loadbalancer/drivers/embrane/driver.py index a6a09fd91..e3014bf0a 100644 --- a/neutron/services/loadbalancer/drivers/embrane/driver.py +++ b/neutron/services/loadbalancer/drivers/embrane/driver.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from heleosapi import backend_operations as h_op from heleosapi import constants as h_con diff --git a/neutron/services/loadbalancer/drivers/embrane/models.py b/neutron/services/loadbalancer/drivers/embrane/models.py index 51adfcf24..55441c7e1 100644 --- a/neutron/services/loadbalancer/drivers/embrane/models.py +++ b/neutron/services/loadbalancer/drivers/embrane/models.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com import sqlalchemy as sql diff --git a/neutron/services/loadbalancer/drivers/embrane/poller.py b/neutron/services/loadbalancer/drivers/embrane/poller.py index bf36079cf..427457ca0 100644 --- a/neutron/services/loadbalancer/drivers/embrane/poller.py +++ b/neutron/services/loadbalancer/drivers/embrane/poller.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com from heleosapi import exceptions as h_exc diff --git a/neutron/services/loadbalancer/drivers/haproxy/__init__.py b/neutron/services/loadbalancer/drivers/haproxy/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/services/loadbalancer/drivers/haproxy/__init__.py +++ b/neutron/services/loadbalancer/drivers/haproxy/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/services/loadbalancer/drivers/haproxy/cfg.py b/neutron/services/loadbalancer/drivers/haproxy/cfg.py index 63aa02da7..1200cf80e 100644 --- a/neutron/services/loadbalancer/drivers/haproxy/cfg.py +++ b/neutron/services/loadbalancer/drivers/haproxy/cfg.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import itertools from six import moves diff --git a/neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py b/neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py index a96b67a2f..04787d430 100644 --- a/neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py +++ b/neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py @@ -11,8 +11,7 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost + import os import shutil import socket diff --git a/neutron/services/loadbalancer/drivers/radware/__init__.py b/neutron/services/loadbalancer/drivers/radware/__init__.py index 4d42f0e62..762b3f333 100644 --- a/neutron/services/loadbalancer/drivers/radware/__init__.py +++ b/neutron/services/loadbalancer/drivers/radware/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware diff --git a/neutron/services/loadbalancer/drivers/radware/driver.py b/neutron/services/loadbalancer/drivers/radware/driver.py index 2fd850be9..23fa2eae1 100644 --- a/neutron/services/loadbalancer/drivers/radware/driver.py +++ b/neutron/services/loadbalancer/drivers/radware/driver.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware import base64 import copy diff --git a/neutron/services/loadbalancer/drivers/radware/exceptions.py b/neutron/services/loadbalancer/drivers/radware/exceptions.py index 4c7b4c5d9..bb16cb755 100644 --- a/neutron/services/loadbalancer/drivers/radware/exceptions.py +++ b/neutron/services/loadbalancer/drivers/radware/exceptions.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Evgeny Fedoruk, Radware from neutron.common import exceptions diff --git a/neutron/services/loadbalancer/plugin.py b/neutron/services/loadbalancer/plugin.py index 6951f1e17..ea5db3b75 100644 --- a/neutron/services/loadbalancer/plugin.py +++ b/neutron/services/loadbalancer/plugin.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware from neutron.api.v2 import attributes as attrs from neutron.common import exceptions as n_exc diff --git a/neutron/tests/unit/services/__init__.py b/neutron/tests/unit/services/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/tests/unit/services/__init__.py +++ b/neutron/tests/unit/services/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/tests/unit/services/loadbalancer/__init__.py b/neutron/tests/unit/services/loadbalancer/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/tests/unit/services/loadbalancer/__init__.py +++ b/neutron/tests/unit/services/loadbalancer/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/tests/unit/services/loadbalancer/agent/test_agent.py b/neutron/tests/unit/services/loadbalancer/agent/test_agent.py index d8dd60513..ae1afe341 100644 --- a/neutron/tests/unit/services/loadbalancer/agent/test_agent.py +++ b/neutron/tests/unit/services/loadbalancer/agent/test_agent.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import contextlib import mock diff --git a/neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py b/neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py index 25c9b4764..4e2842902 100644 --- a/neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py +++ b/neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import contextlib diff --git a/neutron/tests/unit/services/loadbalancer/agent/test_api.py b/neutron/tests/unit/services/loadbalancer/agent/test_api.py index 988ed1f80..3d212a965 100644 --- a/neutron/tests/unit/services/loadbalancer/agent/test_api.py +++ b/neutron/tests/unit/services/loadbalancer/agent/test_api.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import mock diff --git a/neutron/tests/unit/services/loadbalancer/drivers/__init__.py b/neutron/tests/unit/services/loadbalancer/drivers/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/__init__.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_embrane_defaults.py b/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_embrane_defaults.py index 2402b18dc..d061adc26 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_embrane_defaults.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_embrane_defaults.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. from oslo.config import cfg diff --git a/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_plugin_driver.py b/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_plugin_driver.py index 85a35fb46..00771d72a 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_plugin_driver.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/embrane/test_plugin_driver.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Ivar Lazzaro, Embrane, Inc. ivar@embrane.com import sys diff --git a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/__init__.py b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/__init__.py index 44391ce44..69bb9f632 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/__init__.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost diff --git a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_cfg.py b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_cfg.py index 82104e654..1e38822af 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_cfg.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_cfg.py @@ -12,8 +12,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Oleg Bondarev (obondarev@mirantis.com) import contextlib diff --git a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_namespace_driver.py b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_namespace_driver.py index 8649e03b6..45acdf5ee 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_namespace_driver.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_namespace_driver.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import contextlib diff --git a/neutron/tests/unit/services/loadbalancer/drivers/radware/__init__.py b/neutron/tests/unit/services/loadbalancer/drivers/radware/__init__.py index e708e47db..817d20e75 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/radware/__init__.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/radware/__init__.py @@ -11,5 +11,3 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware diff --git a/neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py b/neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py index 027de00b4..3bf18297d 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Avishay Balderman, Radware import re diff --git a/neutron/tests/unit/services/loadbalancer/drivers/test_agent_driver_base.py b/neutron/tests/unit/services/loadbalancer/drivers/test_agent_driver_base.py index 72eb78bbd..812719e4a 100644 --- a/neutron/tests/unit/services/loadbalancer/drivers/test_agent_driver_base.py +++ b/neutron/tests/unit/services/loadbalancer/drivers/test_agent_driver_base.py @@ -11,8 +11,6 @@ # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. -# -# @author: Mark McClain, DreamHost import contextlib