openstack
/
neutron-lbaas
Code Issues Proposed changes

LBaaS V1 Log error instead of exception 

A test was failing because the check for pool orphans was doing a
LOG.exception when there was no exception ever thrown during a unit
test, so the LOG.exception call was failing.  It doesn't make sense
for this piece of code to LOG.exception because there is no
exception being thrown, its throwing its own exception.

Change-Id: I21c12b639d05076f6c89e5c023a60526e81db5b7
Closes-Bug: #1578771
This commit is contained in:
Brandon Logan 2016-05-06 17:51:00 -05:00
parent c851ac5772
commit 75293386e6
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
neutron_lbaas/services/loadbalancer/plugin.py
View File

@ -118,9 +118,8 @@ class LoadBalancerPlugin(ldb.LoadBalancerPluginDb,
if pool['provider'] not in provider_names])
# resources are left without provider - stop the service
if lost_providers:
LOG.exception(_LE("Delete associated loadbalancer pools before "
"removing providers %s"),
list(lost_providers))
LOG.error(_LE("Delete associated loadbalancer pools before "
"removing providers %s"), list(lost_providers))
raise SystemExit(1)
def _get_driver_for_provider(self, provider):